Feature/eja eli 579 adding derivation for previous dose calculations #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of making it compatible with the token parsing logic
… syntax has changed. Going to loop back round and check if we need to specifically re-enable what it was actually testing
…ys with date formatting work
…evious-dose-calculations
eddalmond1
force-pushed
the
feature/eja-eli-579-adding-derivation-for-previous-dose-calculations
branch
2 times, most recently
from
1e2c894 to
122b6dc
Compare
…evious-dose-calculations
…le instances a function
…evious-dose-calculations
…evious-dose-calculations
…evious-dose-calculations
eddalmond1
commented
Jan 13, 2026
| @@ -0,0 +1,28 @@ | |||
| from eligibility_signposting_api.services.processors.derived_values.add_days_handler import AddDaysHandler | |||
Collaborator
Author
There was a problem hiding this comment.
this initialises the set of derived value handlers in the registry on lambda startup
eddalmond1
commented
Jan 13, 2026
| @@ -0,0 +1,180 @@ | |||
| from datetime import UTC, datetime, timedelta | |||
Collaborator
Author
There was a problem hiding this comment.
this is the specific implementation of the 'add days' function
eddalmond1
commented
Jan 13, 2026
| @@ -0,0 +1,67 @@ | |||
| from abc import ABC, abstractmethod | |||
Collaborator
Author
There was a problem hiding this comment.
this is the base class 'template' for all derivation classes
eddalmond1
commented
Jan 13, 2026
| @@ -0,0 +1,164 @@ | |||
| from typing import ClassVar | |||
Collaborator
Author
There was a problem hiding this comment.
this is the 'registry' that allows token text to map to a specific handler and provides the 'calculate' method for that handler to the calling code
eddalmond1
commented
Jan 13, 2026
| Attributes | ||
| ---------- | ||
| attribute_level : str | ||
| Example: "PERSON" or "TARGET" |
Collaborator
Author
There was a problem hiding this comment.
changes to token parser to parse function information
eddalmond1
commented
Jan 13, 2026
| from typing import Any, Never | ||
|
|
||
| from wireup import service | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
added in ability to call the calculate method for a given function after parsing all the arguments etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://nhsd-jira.digital.nhs.uk/browse/ELI-579
COVID-19 Too Close to Previous dose calculation (add days template function). Specifically, adding the ability to have an 'in config' function call to an ADD_DAYS function, which allows the return of relative dates. This functionality leverages the existing token parsing functionality, and extends it to allow function calls beyond date formatting.
Context
Allows us to derive values to return to the user.
I took inspiration from MCP type approaches for LLMs, in that we can set up a 'registry' of tools which we can then make available using the plain text 'function calls'. I've tried to make the approach extendable, so that additional functions for specific purposes can be added by simply creating a class which inherits the base class.
See https://nhsd-confluence.digital.nhs.uk/spaces/Vacc/pages/1254943977/Configuration+driven+derivations for a more in-depth explanation of the changes and how they fit into the existing flow.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.