-
Notifications
You must be signed in to change notification settings - Fork 3
VED-85-Route53-Grafana #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
VED-85-Route53-Grafana #1138
Conversation
|
This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket: VED-85 |
| # Create an A record (alias) pointing to the ALB | ||
| resource "aws_route53_record" "grafana" { | ||
| zone_id = data.aws_route53_zone.grafana_zone.zone_id | ||
| name = "grafana.${local.environment}.imms.dev.vds.platform.nhs.uk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be hardcoded to dev: imms.dev.vds.platform.nhs.uk?
dlzhry2nhs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a staging branch for the grafana work, and then switch and point the PR to it please?
The tickets have been chunked into small pieces, so we will not want to create a PR against master until the full feature is ready.
I am not so familiar with Route53, but I can read up and review. However, it might be good to also refer to a colleague or TL who is more familiar, but I will give it a try.
Finally, once you've developed it please share the output of a plan or apply in the ticket and (optional) Slack channel.
|



Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.