Skip to content

Conversation

@Akol125
Copy link
Contributor

@Akol125 Akol125 commented Jan 15, 2026

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

@github-actions
Copy link
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-85

# Create an A record (alias) pointing to the ALB
resource "aws_route53_record" "grafana" {
zone_id = data.aws_route53_zone.grafana_zone.zone_id
name = "grafana.${local.environment}.imms.dev.vds.platform.nhs.uk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be hardcoded to dev: imms.dev.vds.platform.nhs.uk?

Copy link
Contributor

@dlzhry2nhs dlzhry2nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a staging branch for the grafana work, and then switch and point the PR to it please?

The tickets have been chunked into small pieces, so we will not want to create a PR against master until the full feature is ready.

I am not so familiar with Route53, but I can read up and review. However, it might be good to also refer to a colleague or TL who is more familiar, but I will give it a try.

Finally, once you've developed it please share the output of a plan or apply in the ticket and (optional) Slack channel.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants