[PRMP-975] Document Search Results Backend - Pagination #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
NogaNHS
reviewed
Jan 13, 2026
| modified_doc.document_scan_creation = "2023-05-15" | ||
|
|
||
| patched_service.s3_service.get_file_size.return_value = 8000000 | ||
| # patched_service.s3_service.get_file_size.return_value = 8000000 |
NogaNHS
reviewed
Jan 13, 2026
Comment on lines
47
to
49
| response = camelize_dict(document_reference_search_service.get_paginated_references_by_nhs_number( | ||
| nhs_number=nhs_number, limit=limit, next_page_token=next_page_token, filter=doc_status_filter | ||
| )) |
Contributor
There was a problem hiding this comment.
Can you break this down? a bit hard to read
NogaNHS
reviewed
Jan 13, 2026
| response = camelize_dict(document_reference_search_service.get_paginated_references_by_nhs_number( | ||
| nhs_number=nhs_number, limit=limit, next_page_token=next_page_token, filter=doc_status_filter | ||
| )) | ||
| else: |
Contributor
There was a problem hiding this comment.
Why are we doing this? Can't we use a default limit like review search?
NogaNHS
reviewed
Jan 13, 2026
| def _get_table_name(self, common_name: MtlsCommonNames | None) -> str: | ||
| if not common_name or common_name not in MtlsCommonNames: | ||
| return table_list | ||
| return str(DynamoTables.LLOYD_GEORGE) |
Contributor
There was a problem hiding this comment.
This is StrEnum, why do you need to do this?
Contributor
Author
There was a problem hiding this comment.
changed how we get the table name
NogaNHS
reviewed
Jan 13, 2026
| "operator": ConditionOperator.EQUAL.value, | ||
| "value": filter_value, } | ||
| ) | ||
| return build_mixed_condition_expression(conditions) |
NogaNHS
reviewed
Jan 13, 2026
Comment on lines
272
to
274
| "field": DocumentReferenceMetadataFields.DELETED.value, | ||
| "operator": ConditionOperator.NOT_EQUAL.value, | ||
| "value": True |
NogaNHS
reviewed
Jan 13, 2026
| for filter_key, filter_value in filter_values.items(): | ||
| if filter_key == "custodian": | ||
| conditions.append( | ||
| {"field": DocumentReferenceMetadataFields.CURRENT_GP_ODS.value, |
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
steph-torres-nhs
had a problem deploying
to
development
GitHub Actions
Failure
Code security issues foundView full details here. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Jira ticket: PRMP-975
Description
Adding pagination capability to Document Reference Search
Context
Checklist
Tasks for all changes:
I have run git pre-commits.(WIP)[ ] 4. I have updated relevant documentation.Deploy - Sandbox- workflow run: mainSANDBOX Full- Deploy feature branch to sandbox- workflow run