Feature/ccm 12952 publish mi events #275
Open
+7,422
−10,343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
7 times, most recently
from
6f221b9 to
c9b1df0
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
from
6d0cb00 to
15c58d6
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
2 times, most recently
from
9fcbc8e to
598d07a
Compare
Contributor
|
I seem to remember you mentioning moving both the existing letter transformer and your new MI transformer into a |
stevebux
previously approved these changes
Dec 17, 2025
stevebux
reviewed
Dec 18, 2025
| ); | ||
| }); | ||
|
|
||
| it("does not publish invalid letter data", async () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it("does not publish invalid letter data", async () => { | |
| it("does not publish invalid MI data", async () => { |
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
4 times, most recently
from
52e64d9 to
cefd277
Compare
Vlasis-Perdikidis
previously approved these changes
Dec 24, 2025
masl2
requested changes
Dec 24, 2025
Contributor
masl2
left a comment
masl2
left a comment
There was a problem hiding this comment.
Think we need a guard on the kinesis event type
lambdas/mi-updates-transformer/src/__tests__/mi-updates-transformer.test.ts
Show resolved
Hide resolved
sidnhs
previously approved these changes
Dec 31, 2025
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
3 times, most recently
from
fbd102f to
dc3fd66
Compare
masl2
previously approved these changes
Jan 6, 2026
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
4 times, most recently
from
a1e38b5 to
e51d911
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
from
ff5271d to
83d8343
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-12952-Publish-MI-Events
branch
from
83d8343 to
14578e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.