Conversation
nairoki23
suggested changes
Nov 4, 2023
There was a problem hiding this comment.
慣例的に requirement.txtじゃなくてrequirements.txtじゃね？
Member
Author
There was a problem hiding this comment.
それは僕がコピペしてきたサイトに言ってください...
Member
Author
There was a problem hiding this comment.
まぁ確かにrequirementsのほうが自然ではある
| subjectData[i].append({"subjectName": subjectName, "subjectId": str(i + 1) + tdData[10].string, | ||
| "professor": teachers, "url": url, "room": ""}) | ||
| except KeyError: | ||
| a = 0 |
Member
Author
There was a problem hiding this comment.
あ、そこ消し忘れてた
本当はそこにさらにプログラム書こうと思ってたんだけどやめたんだ
| cb.set(room[len(room) - 1]) | ||
| cb.grid(row=0, column=0) | ||
| # Button | ||
| button1 = ttk.Button( |
There was a problem hiding this comment.
OKボタンを押したときでも、閉じるボタンを押した時みたいにwindowが消える仕様であって欲しい
Member
Author
There was a problem hiding this comment.
僕は嫌なので別で実装してる(取り消すと長時間のスクレイピングをもう一度せざるを得ないので)
| print("\r" + generation_progress_bar(fetchedSubject / allSubjectSiz), end="") | ||
| time.sleep(FETCH_SLEEP) | ||
|
|
||
| for i in range(len(subjectData)): |
| update_room(i, className) | ||
|
|
||
| root = Tk() | ||
| root.title(className + " " + subjectData[i][0]["subjectName"]) |
There was a problem hiding this comment.
重要度低めです。
教科名がwindowの名前でしか確認できないかも不親切な設計かも。
| teachers = [] | ||
| for k in soup.find_all(id="Teachers"): | ||
| teachers.append(k.string) | ||
| subjectData[i].append({"subjectName": subjectName, "subjectId": str(i + 1) + tdData[10].string, |
Comment on lines
+106
to
+107
| grade = int(subjectData[i][0]["subjectId"]) // 10 | ||
| department = int(subjectData[i][0]["subjectId"]) % 10 - 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webシラバスからデータを取得し、辞書型に整形。
ついでにドロップダウンリストを使って部屋を選択できるようにした。