Skip to content

FLOWFarm.jl Integration#182

Open
BTV25 wants to merge 15 commits into
NLRWindSystems:developfrom
BTV25:features/FLOWFarm
Open

FLOWFarm.jl Integration#182
BTV25 wants to merge 15 commits into
NLRWindSystems:developfrom
BTV25:features/FLOWFarm

Conversation

@BTV25
Copy link
Copy Markdown

@BTV25 BTV25 commented Mar 16, 2026

Added FLOWFarm.jl as an aero model. Added integration tests. Added a README specific to FLOWFarm.jl and Julia setup. I attempted to keep the integration as noninvasive as possible, focusing on the fact that Ard should still run without Julia as long as the FLOWFarm model is not being used.

I created a working example that imitates example 01 but just uses the FLOWFarm model.

@BTV25 BTV25 changed the title Features/flow farm FLOWFarm.jl Integration Mar 16, 2026
@cfrontin cfrontin self-requested a review March 19, 2026 20:24
@cfrontin cfrontin self-assigned this Mar 19, 2026
Copy link
Copy Markdown
Collaborator

@cfrontin cfrontin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, this looks pretty good! let's fight through some of the architecture stuff and try to clean up. one thing I was noticing fairly consistently is that there is a lot of complex and potentially over-engineered (possibly AI produced?) code and we should make sure to keep it as simple and clean as possible. FWIW, I'm fine w/ AI-supported code but I do demand a tight leash with it: a human somewhere needs to know what every single line does and why it's necessary.

Comment thread ard/farm_aero/flowfarm/julia_env/Project.toml
Comment thread ard/flowfarm/__init__.py
Comment thread examples/07_flowfarm_setup/inputs/ard_system.yaml Outdated
Comment thread ard/flowfarm/pin_flowfarm.py Outdated
Comment thread test/conftest.py Outdated
Comment thread test/conftest.py
Comment thread .github/workflows/python-tests-consolidated.yaml Outdated
Comment thread ard/farm_aero/flowfarm/README.md
@cfrontin cfrontin requested a review from jaredthomas68 April 2, 2026 22:15
@BTV25 BTV25 requested a review from cfrontin April 10, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants