rev v1 by FelipeMonobe · Pull Request #1 · NOALVO/wireguide

FelipeMonobe · 2018-03-14T21:42:55Z

No description provided.

ggondim · 2018-03-14T23:33:30Z

README.md

 - Modal dialogs

-3.2. _MUST_. For **navigation bars**, when the bar is prefixed by a trademark or logo, include the word `LOGO` at the beggining of the bar.
+3.2. _MUST_ include the word `LOGO` at the beginning of **navigation bars** prefixed by a trademark or logo.


I agree with the new writing, but the initial intention was to focus first in the element and then the rule. In this proposed way, the reader's eyes need to go through the entire sentence to find the element.

Again, I agree with new writing, but it needs a way to put back the element at the beggining.

Since we both agree these changes somehow make sense. And considering we'll eventually segment the text by topics. Isn't it better if we just do it now, instead of reverting back all the changes that are already made by this PR?

ggondim · 2018-03-14T23:55:42Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/32.PNG)

-3.3. _MUST_. **Modal dialogs** must include close button (`×`) at the top-right corner.
+3.3. _MUST_ include close buttons (`×`) at the top-right corner of **modal dialogs**.


I agree with the new writing, but the initial intention was to focus first in the element and then the rule. In this proposed way, the reader's eyes need to go through the entire sentence to find the element.

Again, I agree with new writing, but it needs a way to put back the element at the beggining.

ggondim · 2018-03-14T23:56:24Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/34.PNG)

-3.5. _SHOULD_. For **tables** and **general containers** that includes repeatable elements, draw only the first line of element and include three vertical dots at the middle of container.
+3.5. _SHOULD_ draw only the first line of a repeating elements, followed by a vertical ellipsis (`⋮`) at the middle of  the container for **tables** and **containers**.


Is a repeating elements right?

I agree with the new writing, but the initial intention was to focus first in the element and then the rule. In this proposed way, the reader's eyes need to go through the entire sentence to find the element.

Again, I agree with new writing, but it needs a way to put back the element at the beggining.

No, that a should be omitted, i'm correcting it

ggondim · 2018-03-14T23:58:59Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/35.PNG)

-3.6. _SHOULD_. For **tables** and **general containers** that is supposed to be taller than wireframe bounds, DO NOT finish the container with a bottom side line, and apply a three vertcial dashes following each horizontal side of container.
+3.6. _SHOULD NOT_ draw bottom lines for **tables** and **containers** that are taller than the wireframe. Instead, apply three dashes (like an ellipsis) from each vertical line of the container's sides.


The mention of bounds need to be explicit. If it is not the right word, please suggest a synonym.

When you talk about an object size, you're already considering it's boundaries. So it's redundant to say that. But if you want to emphasize, it's okay, I guess.
So I'm writing it back.

ggondim · 2018-03-15T00:01:05Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/36.PNG)

-3.7. _SHOULD_. For **tables** and **general containers** that is supposed to be wider than wireframe bounds, DO NOT finish the container with a bottom side line, and apply a three horizontal dashes following each vertical side of container.
+3.7. _SHOULD NOT_ draw right/left lines for **tables** and **containers** that are wider than the wireframe. Instead, apply three dashes (like an ellipsis) from each horizontal line of container's sides.


Wider means that only right lines would exist. Left needs to be excluded of the sentence.

The same of 3.6 apply here. The mention of bounds need to be explicit. If it is not the right word, please suggest a synonym.

You put a the before container's sides at 3.6 but not here. Why?

I misunderstood it. I thought it could be represented by either sides, but considering it's a non-established length, it would make no difference, after all.

Fixed.

Fixed.

ggondim · 2018-03-15T00:07:55Z

README.md

+5.1. _MUST_ use **red** color to indicate features' special behaviors.

-5.2. _MUST_. Mark read-only, blocked and disabled controls with an "block" sign.
+5.2. _MUST_ use "blocked" signs (`🚫`) for read-only, blocked or disabled controls.


"Use" is not the proper word for these modifiers. Modifiers are not controls or containers. Controls and containers can be USED, but only can be MARKED with a modifier. If it is not the right word, please suggest a synonym of "mark".

Put marked back

ggondim · 2018-03-15T00:09:07Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/53.PNG)

-5.4. _MUST_. Mark elements and controls that contains or triggers AJAX loaders with an horizontal three-dot.
+5.4. _MUST_ use horizontal ellipsis (`...`) for elements or controls that contain or trigger AJAX loaders.


"Use" is not the proper word for these modifiers. Modifiers are not controls or containers. Controls and containers can be USED, but only can be MARKED with a modifier. If it is not the right word, please suggest a synonym of "mark".

Changed back to marked

ggondim · 2018-03-15T00:09:17Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/54.PNG)

-5.5. _MUST_. Mark elements and controls that are repeatable by some iteration with a vertical three-dot. Indicate more details of the iteration in the Table of Features.
+5.5. _MUST_ use vertical ellipsis (`⋮`) for elements or controls that repeat by some iteration with a vertical three-dot. Indicate more details of the iteration in the Table of Features.


"Use" is not the proper word for these modifiers. Modifiers are not controls or containers. Controls and containers can be USED, but only can be MARKED with a modifier. If it is not the right word, please suggest a synonym of "mark".

HOHO! Found a Table of Features here! :)

Changed back to marked

Keep it there, then

ggondim · 2018-03-15T00:10:19Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/62.PNG)

-6.3. _MUST_. Draw **checkboxes** as squares with a checkmark inside.
+6.3. _MUST_ draw **checkboxes** as squares with a chec kmark inside (`☑`).


checkmark

There was a typo, but it's check mark, though.
Checkmark is a verb, the action of checking a mark.
http://www.dictionary.com/browse/checkmark

ggondim · 2018-03-15T00:13:24Z

README.md

 ![](https://raw.githubusercontent.com/NOALVO/wireguide/master/img/65.PNG)

-6.5.1. _MUST_. For the menu panel, draw it as a black container (as described in 3.1), but make a diagonal (northwest to souteast) line at the top-right corner of the container. 
+6.5.1. _MUST_ draw black containers (as described in 3.1) with a diagonal line from the top to the right line of the container's top-right corner for panel menus.


"Panel menus" doesn't seem to be connected with dropdowns, like I wrote before. In this new writing, I think they can be defined as "dropdown menus".

Actually, neither do

FelipeMonobe · 2018-03-16T00:57:06Z

@ggondim check again for the newest updates

rev v1

d5bc23c

ggondim requested changes Mar 15, 2018

View reviewed changes

FelipeMonobe added 5 commits March 15, 2018 14:27

rev v2, still needs categorization + hyperlinks

1b061b7

added table of contents and categorized text into topics

b32cfb2

trying to fix sublisting before linking

536b3a2

ToC anchors

4662aa2

Fixed topic 5 anchor and added emojis to anchor texts

a609a8a

Comments

Conversation

FelipeMonobe commented Mar 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FelipeMonobe commented Mar 16, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants