Skip to content

feat: add loss comparison for nightly tests #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add loss comparison for nightly tests #784

wants to merge 7 commits into from

Conversation

@adil-a
Copy link
Collaborator

@adil-a adil-a commented Nov 7, 2025 •
edited
Loading

Example run (here it just compares to itself, but the output would be JSONL from the test run):

pytest tests/functional_tests/gt_metrics/test_log_compare.py --ground-truth-jsonl tests/functional_tests/gt_metrics/gpt_oss_20b_te_deepep_train_EP_8.jsonl --compare-jsonl tests/functional_tests/gt_metrics/gpt_oss_20b_te_deepep_train_EP_8.jsonl

@adil-a
stage
bd0ed4a 
Signed-off-by: adil-a <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Nov 7, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@adil-a adil-a linked an issue Nov 7, 2025 that may be closed by this pull request
add loss comparison for nightly CI #783
Open
@adil-a
adding testing util
69ae417 
Signed-off-by: adil-a <[email protected]>
@adil-a adil-a marked this pull request as ready for review November 7, 2025 17:59
adil-a and others added 5 commits November 7, 2025 12:59
@adil-a
Merge branch 'main' into adil/nightly-loss
9b28d40
@adil-a
lint
a0619b0 
Signed-off-by: adil-a <[email protected]>
@adil-a
rename
8bff369 
Signed-off-by: adil-a <[email protected]>
@adil-a
fix
f17c687 
Signed-off-by: adil-a <[email protected]>
@thomasdhc
Add more baselines
2420828 
Signed-off-by: Dong Hyuk Chang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add loss comparison for nightly CI

3 participants

@adil-a @thomasdhc