Merged
Conversation
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
ko3n1g
reviewed
Jan 23, 2026
.github/workflows/release-docs.yml
Outdated
| emails-csv: ${{ inputs.notify-emails && format('{0},{1}', vars.docs_release_emails, inputs.notify-emails) || vars.docs_release_emails }} | ||
| overwrite-latest-on-tag: false | ||
| run-on-version-tag-only: ${{ github.ref_name != 'main' }} | ||
| request-name: megatron-bridge-publish-docs-${{ github.run_id }} |
Contributor
There was a problem hiding this comment.
This line needs an update - not sure about the value though
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Drafting this as we dont have the docs yet |
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Collaborator
Author
|
@ko3n1g what's the harm in merging? |
thomasdhc
approved these changes
Jan 29, 2026
Contributor
It doesn't feel great to have an automation enabled before the first official docs publish. Shall we at least deactivate the workflow to prevent accidental runs? |
Collaborator
Author
|
@ko3n1g Yeah, that makes sense. I'll disable after merging. |
ko3n1g
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add workflow to publish docs