Skip to content

Conversation

@briancoutinho
Copy link

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a way to set the output directory for torch profiling in performance scripts
Collection: N/A

Changelog

  • Adds an option to set the torch profiling output directory either by an environment variable or a cmd line flag in the performance scripts. .

Usage

When Nemo is run in a container/docker the output path basically changes. Use an environment variable or a flag to set this path.

# By setting env. Note this is the path mounted inside the docker image.
export TORCH_PROFILES_DIR='/nemo_run'

# Call perf script
python3 -m scripts.performance.llm.pretrain_nemotronh_....

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc) Bi
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

N?A

Signed-off-by: Brian Coutinho <[email protected]>
@briancoutinho briancoutinho force-pushed the bcoutinho/torch_profiler_out_dir_1104 branch from 2bc4a31 to 8549982 Compare November 4, 2025 19:39
@briancoutinho briancoutinho marked this pull request as ready for review November 4, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant