Skip to content

Conversation

@pablo-garay
Copy link
Collaborator

@pablo-garay pablo-garay commented Nov 4, 2025

chore: remove ExportDeploy

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@pablo-garay pablo-garay force-pushed the pablo-garay/remove_exportDeploy branch from f038494 to 21eaa08 Compare November 4, 2025 23:37
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

[🤖]: Hi @pablo-garay 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@github-actions github-actions bot removed the Run CICD label Nov 4, 2025
@chtruong814
Copy link
Collaborator

Can you see if there's a way to force the CI to run for this PR? It skipped everything. Also, please ensure the cherry pick label is added.

@pablo-garay pablo-garay added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Nov 5, 2025
@pablo-garay
Copy link
Collaborator Author

Can you see if there's a way to force the CI to run for this PR? It skipped everything. Also, please ensure the cherry pick label is added.

Lets see , for now i triggered manually:
https://github.com/NVIDIA-NeMo/NeMo/actions/runs/19094522027
lets monitor the results

oyilmaz-nvidia
oyilmaz-nvidia previously approved these changes Nov 5, 2025
Copy link
Collaborator

@oyilmaz-nvidia oyilmaz-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablo-garay
Copy link
Collaborator Author

/ok to test d3354d2

Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI common NLP r2.6.0 Cherry-pick label for the r2.6.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants