-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix loading of hyb ctc rnnt bpe models when using from pretrained #15042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithinraok <[email protected]>
Signed-off-by: nithinraok <[email protected]>
stevehuang52
approved these changes
Nov 7, 2025
Contributor
|
[🤖]: Hi @nithinraok 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully. So it might be time to merge this PR or get some approvals. |
chtruong814
pushed a commit
that referenced
this pull request
Nov 9, 2025
…5042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: NeMo Bot <[email protected]>
nithinraok
pushed a commit
that referenced
this pull request
Nov 9, 2025
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 14, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 14, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 17, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 17, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 18, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 19, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
genquan9
pushed a commit
to genquan9/NeMo
that referenced
this pull request
Nov 20, 2025
…IDIA-NeMo#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]>
chtruong814
added a commit
that referenced
this pull request
Nov 21, 2025
* Fixing lines for multispeaker pipeline (#15030) * Fixing lines for multispeaker pipeline Signed-off-by: taejinp <[email protected]> * Removing unused imports Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: tango4j <[email protected]> * Making changes for HF Space deployment Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: chtruong814 <[email protected]> * Updated multispk trans utils. Signed-off-by: taejinp <[email protected]> --------- Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Signed-off-by: chtruong814 <[email protected]> Co-authored-by: tango4j <[email protected]> Co-authored-by: chtruong814 <[email protected]> Signed-off-by: genquan9 <[email protected]> * Support gemma3vl tuning with verified performances Signed-off-by: genquan9 <[email protected]> * minor update gemma3vl parameters for easier usages Signed-off-by: genquan9 <[email protected]> * Apply isort and black reformatting Signed-off-by: genquan9 <[email protected]> Signed-off-by: genquan9 <[email protected]> * Inference optimization for cache-aware pipelines (#15035) * optimize context manager and cache feature bufferer Signed-off-by: naymaraq <[email protected]> * speedUp cache_feature_bufferer Signed-off-by: naymaraq <[email protected]> * improved docstring in BatchedCacheFeatureBufferer Signed-off-by: naymaraq <[email protected]> --------- Signed-off-by: naymaraq <[email protected]> Co-authored-by: naymaraq <[email protected]> Signed-off-by: genquan9 <[email protected]> * fix loading of hyb ctc rnnt bpe models when using from pretrained (#15042) * fix loading of hyb ctc rnnt bpe models when using from pretrained Signed-off-by: nithinraok <[email protected]> * Apply isort and black reformatting Signed-off-by: nithinraok <[email protected]> --------- Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]> * revert ckpt scripts removal from #14617 (#15048) Signed-off-by: genquan9 <[email protected]> * chore: remove ExportDeploy (#15033) * add EP in PTQ (#15015) Signed-off-by: jenchen13 <[email protected]> Signed-off-by: Pablo Garay <[email protected]> * remove ExportDeploy Signed-off-by: Pablo Garay <[email protected]> * remove exportDeploy tests Signed-off-by: Pablo Garay <[email protected]> * remove references Signed-off-by: Pablo Garay <[email protected]> * lintfix Signed-off-by: Pablo Garay <[email protected]> * Fixing lines for multispeaker pipeline (#15030) * Fixing lines for multispeaker pipeline Signed-off-by: taejinp <[email protected]> * Removing unused imports Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: tango4j <[email protected]> * Making changes for HF Space deployment Signed-off-by: taejinp <[email protected]> * Apply isort and black reformatting Signed-off-by: chtruong814 <[email protected]> * Updated multispk trans utils. Signed-off-by: taejinp <[email protected]> --------- Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Signed-off-by: chtruong814 <[email protected]> Co-authored-by: tango4j <[email protected]> Co-authored-by: chtruong814 <[email protected]> Signed-off-by: Pablo Garay <[email protected]> * remove ExportDeploy & references Signed-off-by: Pablo Garay <[email protected]> * lintfix Signed-off-by: Pablo Garay <[email protected]> * get load_ckpt back Signed-off-by: Pablo Garay <[email protected]> * lintfix Signed-off-by: Pablo Garay <[email protected]> * Apply isort and black reformatting Signed-off-by: pablo-garay <[email protected]> * back Signed-off-by: Pablo Garay <[email protected]> * revert back Signed-off-by: Pablo Garay <[email protected]> * revert back Signed-off-by: Pablo Garay <[email protected]> * remove ExportDeploy Signed-off-by: Pablo Garay <[email protected]> --------- Signed-off-by: jenchen13 <[email protected]> Signed-off-by: Pablo Garay <[email protected]> Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Signed-off-by: chtruong814 <[email protected]> Signed-off-by: pablo-garay <[email protected]> Co-authored-by: Jenny Chen <[email protected]> Co-authored-by: Taejin Park <[email protected]> Co-authored-by: tango4j <[email protected]> Co-authored-by: chtruong814 <[email protected]> Co-authored-by: pablo-garay <[email protected]> Signed-off-by: genquan9 <[email protected]> * fix after ED remove (#15051) Signed-off-by: Pablo Garay <[email protected]> Signed-off-by: genquan9 <[email protected]> * Update changelog for `v2.5.3` (#15055) * beep boop: Update changelog Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update changelog for 2.5.3 Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Charlie Truong <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Charlie Truong <[email protected]> Signed-off-by: genquan9 <[email protected]> * [voice agent] Fix RTVI missing bot message (#15068) * fix RTVI missing bot message, fix diar not passing VAD frames Signed-off-by: stevehuang52 <[email protected]> * revert change to diar Signed-off-by: stevehuang52 <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: genquan9 <[email protected]> * [voice agent] make parakeet-eou model default stt (#15069) * make eou model default stt Signed-off-by: stevehuang52 <[email protected]> * fix typo Signed-off-by: stevehuang52 <[email protected]> * clean up doc Signed-off-by: stevehuang52 <[email protected]> --------- Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: genquan9 <[email protected]> * minor fixes to remove unused headers/lines and add exception Signed-off-by: genquan9 <[email protected]> * resolve merge conflicts from github Signed-off-by: genquan9 <[email protected]> * removed old buffered CTC script (#15061) * removed old buffered CTC script Signed-off-by: naymaraq <[email protected]> * remove references to speech_to_text_buffered_infer_ctc.py Signed-off-by: naymaraq <[email protected]> --------- Signed-off-by: naymaraq <[email protected]> Co-authored-by: naymaraq <[email protected]> Signed-off-by: genquan9 <[email protected]> * remove unused imports Signed-off-by: genquan9 <[email protected]> * remove nlp related notebooks (#15070) Signed-off-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]> * chore: Remove Automodel module (#15044) * Delete Automodel module Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove additional code using or importing automodel pathway Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove unused import Signed-off-by: Dong Hyuk Chang <[email protected]> * Further remove hf automodel testing and hf automodel in vlm Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove unused vars Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove automodel instance in model opt Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove hf_auto_model_for_causal_ln Signed-off-by: Dong Hyuk Chang <[email protected]> * Delete HFAutomodel from speech Signed-off-by: Dong Hyuk Chang <[email protected]> * Add noqa Signed-off-by: Dong Hyuk Chang <[email protected]> * Apply isort and black reformatting Signed-off-by: thomasdhc <[email protected]> * Remove automodel related tests Signed-off-by: Dong Hyuk Chang <[email protected]> * Update init file to use import Signed-off-by: Dong Hyuk Chang <[email protected]> * Apply isort and black reformatting Signed-off-by: thomasdhc <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Signed-off-by: thomasdhc <[email protected]> Co-authored-by: thomasdhc <[email protected]> Signed-off-by: genquan9 <[email protected]> * add support for parallel ckpt removal (#15073) * add support for parallel ckpt removal Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]> Signed-off-by: genquan9 <[email protected]> * Fix vlm engine changes in mcore (#15076) Signed-off-by: genquan9 <[email protected]> * Add docstring for encode_vqa_sample_multi_turns, and fix long comments Signed-off-by: genquan9 <[email protected]> * Update MagpieTTS model with latest changes (#15031) * Update MagpieTTS Signed-off-by: Jason <[email protected]> * allow None in dataset path Signed-off-by: Jason <[email protected]> * try to fix test by removing lhotse; fix yamls in fast dev run tests Signed-off-by: Jason <[email protected]> * increase zeroshot cer value; attempt to fix PO test; add back lhotse in parakeet inference to test segmentation fault Signed-off-by: Jason <[email protected]> * remove branch from test Signed-off-by: Jason <[email protected]> * use batch_size 1 Signed-off-by: Jason <[email protected]> * update GRPO test script Signed-off-by: Jason <[email protected]> * add use_lhotse as a param to transcribe; attempt to fix PO test again; attempt to catch error Signed-off-by: Jason <[email protected]> * fix tests Signed-off-by: Jason <[email protected]> * update rnnt transcribe; fix po test again Signed-off-by: Jason <[email protected]> * Apply suggestion from @XuesongYang Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> * Move FCD copyright text from TorchEval to top of file Signed-off-by: Fejgin, Roy <[email protected]> * Remove duplicate copyright text It is now at the top of the file. Signed-off-by: Fejgin, Roy <[email protected]> * Apply suggestion from @XuesongYang Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> * Apply suggestion from @XuesongYang Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> * Apply suggestion from @XuesongYang Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> * Apply suggestion from @XuesongYang Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> * Fix OnlinePO test: escape a special character in command line Signed-off-by: Fejgin, Roy <[email protected]> * Easier-to-read way to quote a special character in OnlinePO test Signed-off-by: Fejgin, Roy <[email protected]> * Work around ASR Lhotse issue ... and remove some debug code. Signed-off-by: Fejgin, Roy <[email protected]> * Remove FCD metric for now Signed-off-by: Fejgin, Roy <[email protected]> * Remove unused import Signed-off-by: Fejgin, Roy <[email protected]> * Update examples/tts/conf/magpietts/magpietts_lhotse.yaml Signed-off-by: Fejgin, Roy <[email protected]> Signed-off-by: Roy Fejgin <[email protected]> --------- Signed-off-by: Jason <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Fejgin, Roy <[email protected]> Signed-off-by: Roy Fejgin <[email protected]> Co-authored-by: Xuesong Yang <[email protected]> Co-authored-by: Fejgin, Roy <[email protected]> Signed-off-by: genquan9 <[email protected]> * Revert "Fix vlm engine changes in mcore (#15076)" (#15090) This reverts commit b557cfd. Signed-off-by: genquan9 <[email protected]> * ASR inference: expose RNN-T decoding params for context biasing (#15091) * ASR Inference: load decoding params from config for RNN-T Signed-off-by: Vladimir Bataev <[email protected]> Signed-off-by: genquan9 <[email protected]> * Fix vlm engine changes in mcore (#15076) Signed-off-by: genquan9 <[email protected]> * Revert "Fix vlm engine changes in mcore (#15076)" (#15090) This reverts commit b557cfd. Signed-off-by: genquan9 <[email protected]> * update notebook (#15093) Signed-off-by: nithinraok <[email protected]> Signed-off-by: genquan9 <[email protected]> * fix lines with malformed anchor tags (#15095) Signed-off-by: Pablo Garay <[email protected]> Signed-off-by: genquan9 <[email protected]> * add copyright header for missing files Signed-off-by: genquan9 <[email protected]> --------- Signed-off-by: taejinp <[email protected]> Signed-off-by: tango4j <[email protected]> Signed-off-by: chtruong814 <[email protected]> Signed-off-by: genquan9 <[email protected]> Signed-off-by: genquan9 <[email protected]> Signed-off-by: naymaraq <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: jenchen13 <[email protected]> Signed-off-by: Pablo Garay <[email protected]> Signed-off-by: pablo-garay <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Charlie Truong <[email protected]> Signed-off-by: stevehuang52 <[email protected]> Signed-off-by: He Huang (Steve) <[email protected]> Signed-off-by: Dong Hyuk Chang <[email protected]> Signed-off-by: thomasdhc <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Signed-off-by: Jason <[email protected]> Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Fejgin, Roy <[email protected]> Signed-off-by: Roy Fejgin <[email protected]> Signed-off-by: Vladimir Bataev <[email protected]> Co-authored-by: Taejin Park <[email protected]> Co-authored-by: tango4j <[email protected]> Co-authored-by: chtruong814 <[email protected]> Co-authored-by: genquan9 <[email protected]> Co-authored-by: Dav Karamyan <[email protected]> Co-authored-by: naymaraq <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: nithinraok <[email protected]> Co-authored-by: Dmytro Pykhtar <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Jenny Chen <[email protected]> Co-authored-by: pablo-garay <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Charlie Truong <[email protected]> Co-authored-by: He Huang (Steve) <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Co-authored-by: thomasdhc <[email protected]> Co-authored-by: dimapihtar <[email protected]> Co-authored-by: meatybobby <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Xuesong Yang <[email protected]> Co-authored-by: Fejgin, Roy <[email protected]> Co-authored-by: Vladimir Bataev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes issue when loading hybrid rnnt ctc models with .from_pretrained() method
Collection: ASR
Changelog
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information