Skip to content

feat(auth): add typed IAM NemoClient#801

Draft
maxdubrinsky wants to merge 3 commits into
mainfrom
aircore-878-migrate-auth-crud-to-nemoclient/md
Draft

feat(auth): add typed IAM NemoClient#801
maxdubrinsky wants to merge 3 commits into
mainfrom
aircore-878-migrate-auth-crud-to-nemoclient/md

Conversation

@maxdubrinsky

@maxdubrinsky maxdubrinsky commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add typed sync and async IAM clients for role-binding CRUD, PDP authorization evaluation, and OPA bundle retrieval.
  • Share the IAM wire DTOs with the Auth service without changing OIDC discovery/bootstrap or nmp_common.AuthClient.
  • Preserve binary response metadata after reads and scope HTTP 304 acceptance to endpoints that explicitly declare it.
  • Model the structured FastAPI authorization 400 envelope and retain the existing public IAM/OpenAPI contracts.

Validation

  • 216 IAM/client/Auth tests passed after merging current main; 4 slow stress tests skipped by the standard suite.
  • Ruff, formatting, focused ty, deterministic OpenAPI regeneration, and git diff --check passed.
  • Independent adversarial review found no blocker.

Exclusions

OIDC discovery/bootstrap and nmp_common.AuthClient remain unchanged by design.

Linear: https://linear.app/nvidia/issue/AIRCORE-878

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
@github-actions github-actions Bot added the feat label Jul 20, 2026
Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
@github-actions

github-actions Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 26445/34091 77.6% 61.8%
Integration Tests 15232/32716 46.6% 18.7%

Signed-off-by: Max Dubrinsky <mdubrinsky@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant