fix(models): fix default model_puller image for NIMCache#804
fix(models): fix default model_puller image for NIMCache#804anubhutivyas wants to merge 2 commits into
Conversation
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
fa7db5c to
6421ccc
Compare
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe NIM operator now configures its Hugging Face model puller through ChangesNIM operator model puller
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Comment |
There was a problem hiding this comment.
Since you added the model puller to the K8sNimOperatorConfig, this is redundant information. We should just rely on the backend_config.huggingface_model_puller.
There was a problem hiding this comment.
This was actually left as is intentionally because I didn't want to touch the tool-call-plugin's container image, but thinking through this I feel it won't break anything as we were using the nds image earlier too. Removed _huggingface_model_puller from contructor and now using backend_config.huggingface_model_puller everywhere.
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
|
Closing it because we have removed the k8s-nim-operator in this PR - #705 |
Issue:
NIMCachepod runs the platformnmp-apiimage, which does not containdownload-to-cache.compile_nimcachebuilds a NIMCache CR where the HF source modelPuller is set from the models service'shuggingface_model_pullerwhose value is set tonmp-apiimage by defaultChange:
Following how we have a separate field in
DockerBackendConfigfor docker backend, create a new fieldhuggingface_model_pullerinK8sNimOperatorConfigand set the default asnds-v2-huggingface-cli:25.10, which ships download-to-cache.Summary by CodeRabbit