feat(studio): Dedicated Agent Details Page#806
Open
steramae-nvidia wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesAgent detail experience
Sequence Diagram(s)sequenceDiagram
participant AgentsListRoute
participant AgentDetailRoute
participant useAgentPanel
participant DeploymentsTab
participant ChatPlayground
AgentsListRoute->>AgentDetailRoute: navigate to agent details
AgentDetailRoute->>useAgentPanel: load agent data
useAgentPanel-->>AgentDetailRoute: return agent, deployments, evaluations
AgentDetailRoute->>DeploymentsTab: render deployment data and callbacks
AgentDetailRoute->>ChatPlayground: render selected chat tab
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (3)
web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx (3)
4-10: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winGroup external imports before internal imports.
Move
@testing-library/user-eventabove the@studio/*imports.As per coding guidelines, follow “Group imports: external libraries, internal modules, relative imports in TypeScript.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 4 - 10, Reorder the imports in the AgentDetailRoute test so the external `@testing-library/user-event` import appears before all internal `@studio/`* imports, while preserving the existing import statements.Source: Coding guidelines
36-43: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winVerify Chat updates the URL.
This only checks
aria-selected; a regression in the route’s search-parameter synchronization would pass. Assert the memory router’s location contains the expected tab search parameter after clicking Chat.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 36 - 43, Update the “switches to the chat tab” test to also inspect the memory router location after clicking the Chat tab, asserting that the URL search parameters contain the expected Chat tab value while preserving the existing aria-selected and textbox assertions.
21-33: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAssert the default tab’s content.
The test verifies that Overview is selected but not that its panel renders. Add a stable assertion for the Overview content, such as
Overview is coming soon.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 21 - 33, Add an assertion in the “renders the agent as a full page with tabs and header actions” test that verifies the selected Overview panel content, using the stable text “Overview is coming soon” while preserving the existing tab and header-action assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx`:
- Around line 4-10: Reorder the imports in the AgentDetailRoute test so the
external `@testing-library/user-event` import appears before all internal
`@studio/`* imports, while preserving the existing import statements.
- Around line 36-43: Update the “switches to the chat tab” test to also inspect
the memory router location after clicking the Chat tab, asserting that the URL
search parameters contain the expected Chat tab value while preserving the
existing aria-selected and textbox assertions.
- Around line 21-33: Add an assertion in the “renders the agent as a full page
with tabs and header actions” test that verifies the selected Overview panel
content, using the stable text “Overview is coming soon” while preserving the
existing tab and header-action assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: af148d44-30c1-4122-a554-cd0a1c189b57
📒 Files selected for processing (10)
web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/DeploymentsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/EvaluationsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/TabPlaceholder.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/overview/DetailPanel.tsxweb/packages/studio/src/routes/agents/AgentsListRoute/index.tsxweb/packages/studio/src/routes/groups/agentRoutes.tsx
Contributor
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style
Tests