fix(models): redirect LoRA sidecar XDG_DATA_HOME to a writable volume#842
Merged
Conversation
Follow-up to #798, which redirected only $XDG_STATE_HOME. The adapters sidecar's `nemo services run` also resolves its local data dir (SQLite DB, encryption key) via nmp_user_data_dir(), which honors $XDG_DATA_HOME (default ~/.local/share/nemo) -- a distinct XDG home from $XDG_STATE_HOME (default ~/.local/state). The pod runs the sidecar as the vLLM uid (2000), which does not own the nmp-api image's baked $HOME (/home/nvs, uid 1000), so startup still crash-looped with `PermissionError: [Errno 13] Permission denied: '/home/nvs/.local'` when mkdir'ing ~/.local/share/nemo. Point both XDG homes at a single writable scratch base (/scratch/.local), named for the ~/.local these homes normally live under. State lands under .../nmp/ and data under .../nemo/, so one base holds both without collision, and it stays outside the /scratch/loras subtree the adapters controller GCs. Covered by the deployments_plugin compiler unit test. Signed-off-by: Albert Cui <albcui@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesLoRA sidecar XDG configuration
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
|
mckornfield
approved these changes
Jul 22, 2026
Signed-off-by: Albert Cui <albcui@nvidia.com>
albcui
enabled auto-merge
July 22, 2026 15:31
soluwalana
pushed a commit
that referenced
this pull request
Jul 22, 2026
…#842) * fix(models): redirect LoRA sidecar XDG_DATA_HOME to a writable volume Follow-up to #798, which redirected only $XDG_STATE_HOME. The adapters sidecar's `nemo services run` also resolves its local data dir (SQLite DB, encryption key) via nmp_user_data_dir(), which honors $XDG_DATA_HOME (default ~/.local/share/nemo) -- a distinct XDG home from $XDG_STATE_HOME (default ~/.local/state). The pod runs the sidecar as the vLLM uid (2000), which does not own the nmp-api image's baked $HOME (/home/nvs, uid 1000), so startup still crash-looped with `PermissionError: [Errno 13] Permission denied: '/home/nvs/.local'` when mkdir'ing ~/.local/share/nemo. Point both XDG homes at a single writable scratch base (/scratch/.local), named for the ~/.local these homes normally live under. State lands under .../nmp/ and data under .../nemo/, so one base holds both without collision, and it stays outside the /scratch/loras subtree the adapters controller GCs. Covered by the deployments_plugin compiler unit test. Signed-off-by: Albert Cui <albcui@nvidia.com> * Make comments less verbose Signed-off-by: Albert Cui <albcui@nvidia.com> --------- Signed-off-by: Albert Cui <albcui@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #798, which redirected only
$XDG_STATE_HOME. The adapters sidecar'snemo services runalso resolves its local data dir via$XDG_DATA_HOME(default~/.local/share/nemo). This leads to the same class of permission issue surfaced previously.Point both XDG homes at a single writable scratch base (
/scratch/.local). State lands under.../nmp/and data under.../nemo/, so one base holds both without collision, and it stays outside the/scratch/lorassubtree the adapters controller GCs. Covered by the deployments_plugin compiler unit test.Summary by CodeRabbit
XDG_STATE_HOMEandXDG_DATA_HOMEto the same writable scratch-backed base location, reducing permission-related issues.