Repository navigation
Add Metal 4 support to samples - #28
Open
selimsandal wants to merge 4 commits into
Open
selimsandal wants to merge 4 commits into
selimsandal wants to merge 4 commits into
Conversation
- Resize: tracked window size in points and output resolution in pixels - Wrapper: enabled "VK_KHR_portability_subset" if supported (MoltenVK) - DescriptorPoolIndexing: required "features.mutableDescriptorType" - CopyTests: added ETC2 and ASTC host copies - DeviceInfo: accepted "--api=D3D11" - added GraphicsVertexInput: vertex input, geometry and tessellation draw testing
- accepted "--api=METAL" in test samples and DeviceInfo, Metal is the default on Apple platforms if Metal Shader Converter is enabled - compiled DXIL for Metal Shader Converter with "NRI_METAL_DXIL" - used draw parameters emulation on Metal (DXIL) in BindlessSceneViewer - avoided "SV_ViewID" in Triangle and Multisample on Metal (unsupported by Metal Shader Converter) - Wrapper: Metal device wrapping is not demonstrated
Every sample has a different value and sample 0 is neither the minimum, nor the maximum, nor the average. Covers integer color, depth and stencil through attachments and "CmdResolveTexture", depth "MIN" with a separate stencil "SAMPLE_ZERO", and a depth/stencil plane upload/readback round trip, for "D32_SFLOAT_S8_UINT" and "D24_UNORM_S8_UINT". Unsupported cases are skipped based on "DeviceDesc::resolve".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VK_KHR_portability_subsetwhen the device has it (MoltenVK), and DescriptorPoolIndexing checksfeatures.mutableDescriptorTypebefore usingMUTABLEdescriptors.--api=D3D11.--api=METAL, and HLSL is compiled with-D NRI_METAL_DXILfor the converter. BindlessSceneViewer, Triangle, Multisample and Wrapper have small Metal fixes.This depends on the NRIFramework PR. I'll bump
External/NRIFrameworkonce it's merged.