Skip to content

ci[maxtext]: adds rosetta directory to maxtext containers #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci[maxtext]: adds rosetta directory to maxtext containers #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/container/Dockerfile.maxtext.amd64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ EOF
## Add test script to the path
###############################################################################

ADD test-maxtext.sh /usr/local/bin
ADD .github/container/test-maxtext.sh /usr/local/bin
ADD rosetta /opt/rosetta

###############################################################################
## Install accumulated packages from the base image and the previous stage
Expand All @@ -31,4 +32,4 @@ FROM mealkit as final

RUN pip-finalize.sh

WORKDIR ${SRC_PATH_MAXTEXT}
WORKDIR ${SRC_PATH_MAXTEXT}
3 changes: 2 additions & 1 deletion .github/container/Dockerfile.maxtext.arm64
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ EOF
## Add test script to the path
###############################################################################

ADD test-maxtext.sh /usr/local/bin
ADD .github/container/test-maxtext.sh /usr/local/bin
ADD rosetta /opt/rosetta

###############################################################################
## Install accumulated packages from the base image and the previous stage
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ jobs:
BASE_IMAGE: ${{ needs.build-jax.outputs.DOCKER_TAG_MEALKIT }}
CONTAINER_NAME: maxtext
DOCKERFILE: .github/container/Dockerfile.maxtext.${{ inputs.ARCHITECTURE }}
DOCKER_CONTEXT: .
EXTRA_BUILD_ARGS: |
URLREF_MAXTEXT=${{ fromJson(inputs.SOURCE_URLREFS).MAXTEXT }}
secrets: inherit
Expand Down
Loading