Skip to content

docs(e2e): sync full-e2e budget note#6762

Merged
miyoungc merged 1 commit into
NVIDIA:mainfrom
HwangJohn:docs/6660-full-e2e-budget
Jul 13, 2026
Merged

docs(e2e): sync full-e2e budget note#6762
miyoungc merged 1 commit into
NVIDIA:mainfrom
HwangJohn:docs/6660-full-e2e-budget

Conversation

@HwangJohn

@HwangJohn HwangJohn commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Sync the full-e2e README budget prose with the current hard total budget. The live full-E2E test uses a 205-second total budget, but the README still described the old 180-second limit.

Related Issue

Refs #6660.

Changes

  • Update the test/e2e/README.md onboard performance budget section from 180 seconds to 205 seconds.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification: prose-only README sync; no runtime behavior changes.
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: this PR updates test-harness documentation only and does not change user-facing docs under docs/.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hook-equivalent checks passed
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: tests not applicable; rg -n "ONBOARD_BUDGET_SECS|180 seconds|205 seconds" test/e2e/README.md test/e2e/live/full-e2e.test.ts confirms the README now matches the 205-second budget source.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: HwangJohn angelic805@gmail.com

Summary by CodeRabbit

  • Documentation
    • Updated the end-to-end onboarding performance budget to allow up to 205 seconds for the full cold-path flow.
    • Retained the existing measurement process and output-gap requirement.

Signed-off-by: HwangJohn <angelic805@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: cbd0261e-36e8-4065-8891-2d7f331a04b4

📥 Commits

Reviewing files that changed from the base of the PR and between 3de1de6 and 85dff98.

📒 Files selected for processing (1)
  • test/e2e/README.md

📝 Walkthrough

Walkthrough

The E2E README updates the full-e2e hard cold-path total-duration limit from 180 seconds to 205 seconds while retaining the existing measurement flow and output-gap constraint.

Changes

E2E Performance Budget

Layer / File(s) Summary
Update onboarding duration threshold
test/e2e/README.md
The documented full-e2e total-duration limit increases from 180 seconds to 205 seconds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: v0.0.68

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the documentation-only update to the full-e2e budget note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: target/main
Head: HEAD
Confidence: high

Required E2E

  • None. This PR changes only E2E documentation. It does not alter the full-e2e test, CI workflow, onboarding implementation, or any runtime behavior, so no E2E job is needed.

Optional E2E

  • None.

New E2E recommendations

  • None.

@wscurran wscurran added area: docs Documentation, examples, guides, or docs build area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance labels Jul 13, 2026
@wscurran

Copy link
Copy Markdown
Contributor

✨ Thanks for the docs sync, @HwangJohn. Updating the README budget to match the current 205-second total keeps the test harness documentation accurate. Ready for maintainer review.


Related open issues:

@miyoungc
miyoungc merged commit 9812df1 into NVIDIA:main Jul 13, 2026
33 of 35 checks passed
@github-actions github-actions Bot added the v0.0.82 Release target label Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance v0.0.82 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants