fix(ci): run reviewed control-plane E2E - #6826
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Nemotron is a non-blocking second opinion. Its prose, findings, and E2E guidance do not change the primary assessment above and remain in workflow artifacts only. E2E guidanceAdvisory only: coverage and selector recommendations are non-authoritative. E2E / PR Gate independently computes and dispatches trusted jobs without consuming this output. Recommended coverage:
This is an automated, non-authoritative review. Findings are inputs to maintainer adjudication. Warnings and optional suggestions do not require a response or follow-up. A human maintainer makes the final merge decision. |
|
Bootstrap validation for exact head
|
Summary
Controller-only internal PRs now automatically dispatch the selected exact-SHA E2E jobs instead of requiring a no-run exception. Internal changes that alter PR-controlled E2E execution or evidence code require an explicit maintainer/admin
run-control-planeauthorization, then use the normal dispatch, wait, evidence, and finish path so only verified results can clearE2E / PR Gate. Fork handling remains a no-secret exception.Related Issue
Part of #6145
Changes
.github/workflows/pr-e2e-gate.yamlandtools/e2e/pr-e2e-gate.mtsas controller-only control-plane changes eligible for automatic internal dispatch.resolve-control-planeno-run waiver with exact-head/baserun-control-planeauthorization that requiresmaintainoradminand dispatches the selected jobs.Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run test/pr-risk-plan.test.ts test/pr-e2e-gate-command.test.ts test/pr-e2e-gate-workflow.test.ts test/pr-e2e-gate-exceptions.test.ts test/pr-e2e-gate.test.ts(154 passed)npm testdid not complete: after eight minutes it remained on one idle integration worker with an orphaned persistent-logtail -F; the process was terminated and GitHub CI is required for the broad verdict.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
New Features
Bug Fixes
Documentation