test(macos): accept canonical watcher paths

[ericksoa]

Summary

• Keep the installer production contract unchanged: relative OpenShell overrides are resolved to an absolute physical path with pwd -P.
• Make the focused test assert the actual contract: the watcher receives an absolute path resolving to the same executable.
• Accept the standard macOS /var to /private/var canonicalization.

Why

The post-merge main platform watch failed only because the test compared path spellings lexically. The identical assertion failed on the immediately previous completed main-watch run and on the first completed run after the test was introduced, so this was not introduced by #7280.

Evidence: https://github.com/NVIDIA/NemoClaw/actions/runs/29910675239/job/88892568917 and https://github.com/NVIDIA/NemoClaw/actions/runs/29897085188/job/88849484779

Verification

• CI=1 npx vitest run --project cli src/lib/actions/uninstall/hermes-forward-watcher-installer.test.ts --reporter=verbose
• npx @biomejs/biome check src/lib/actions/uninstall/hermes-forward-watcher-installer.test.ts
• npm run build:cli && npm run typecheck
• git diff --check

Signed-off-by: Aaron Erickson aerickson@nvidia.com

Summary by CodeRabbit

• Tests
  • Updated coverage to verify that the Hermes forward watcher logs an absolute OpenShell path.
  • Confirmed the logged path resolves to the same filesystem target as the generated executable.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eed5f496-7674-41c9-ac5d-8f8dd57ddbe3

📥 Commits

Reviewing files that changed from the base of the PR and between 059f328 and 64416fe.

📒 Files selected for processing (1)

• src/lib/actions/uninstall/hermes-forward-watcher-installer.test.ts

---

📝 Walkthrough

Walkthrough

The Hermes forward watcher installer test now verifies that the logged OpenShell path is absolute and resolves to the same filesystem target as the generated executable.

Changes

Hermes watcher installer validation

Layer / File(s)	Summary
Validate logged OpenShell path src/lib/actions/uninstall/hermes-forward-watcher-installer.test.ts	The test asserts that the logged path is absolute and that its resolved real path matches the generated openshell executable.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: laitingsheng

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title matches the main change: a macOS test update to accept canonical watcher paths.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-macos-openshell-path

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 64416fe in the codex/fix-macos-open... branch remains at 96%, unchanged from commit 059f328 in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 64416fe in the codex/fix-macos-open... branch remains at 80%, unchanged from commit 059f328 in the main branch.

Show a code coverage summary of the most impacted files.

File	main 059f328	codex/fix-macos-open... 64416fe	+/-
src/lib/platform.ts	89%	84%	-5%
src/lib/agent/r...ime-manifest.ts	100%	100%	0%
src/lib/messagi...nnels/policy.ts	100%	100%	0%
src/lib/sandbox...rce-identity.ts	87%	87%	0%
src/lib/securit...ntial-filter.ts	93%	93%	0%
src/lib/trace.ts	94%	94%	0%
src/lib/adapter...shell/client.ts	88%	90%	+2%
src/lib/state/m...-acquisition.ts	86%	89%	+3%
src/lib/domain/.../connect-env.ts	89%	97%	+8%

---

_{Updated July 22, 2026 11:10 UTC}

[github-actions]

PR Review Advisor — Informational

Advisor assessment: Informational / high confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized E2E selections differ; severity counts match.

Nemotron output stays in workflow artifacts and does not change the assessment above.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

2 optional E2E recommendations

• bootstrap-install-smoke
• hermes-e2e

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.