Repository navigation
fix(sandbox): name Landlock ABI in startup error - #4413
Conversation
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
/ok to test 7b0da8b |
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
The independent code review found no blocking issues in the shared Landlock ABI check or its earlier startup qualification. The diagnostic tests and Fern docs cover the stated change; required CI is now running on this head.
Blocking findings: None.
Carried findings: None.
Gator metadata
- Validation: Focused sandbox startup diagnostic fix for #4296; no duplicate active PR identified.
- Docs: Updated
docs/how-it-works/policies/schema.mdx; no navigation change needed. - Checks: DCO and vouch passed. Branch Checks, Helm Lint, and Trivy Changes are running on the current head. Trivy workflow approval succeeded.
- E2E: Applied
test:e2ebefore the authorized/ok to testcommand created the current-head mirror. Standard E2E is running with image and binary builds active. The label-help bot requested a rerun; GitHub refused because the run is already active. No additional attempt was queued; monitor the existing run, which picked up the label. - Head SHA:
7b0da8b1faec3a5ab2002ff84f6070140eca8980 - Base SHA:
77c5ff6e20c98b3674616ecf35b2464f2b8e57ca - Merge base SHA:
77c5ff6e20c98b3674616ecf35b2464f2b8e57ca - Patch ID:
9f72d488ebc418d045ef016c0e71f98b755b9c42 - Gator payload:
12 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:watch-pipeline
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: The PR was awaiting maintainer approval when monitoring resumed; GitHub now confirms it is merged. I removed the active Gator metadata
|
Summary
On a kernel below Landlock ABI v3, startup failed with an opaque ruleset error. Name the required and detected ABI instead.
Related Issue
Closes #4296
Changes
require_abicheck, used by the qualification probe and the baseline.probe_availabilityreusesabi_versioninstead of a second syscall.Testing
cargo fmt,cargo clippy --all-targets(alsoperf-harness) andcargo testforopenshell-sandbox, andmise run docs.capability_free_baseline_drops_each_root_entry_before_opening_the_nextfails in parallel runs onmaintoo and passes with--test-threads=1. E2E not run locally.Checklist