Skip to content

[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for… - #16266

Open
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6435097
Open

[https://nvbugs/6435097][fix] Remove the single stale nvbugs/6427411 waiver line for…#16266
trtllm-agent wants to merge 1 commit into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6435097

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Dev Engineer Review

  • Removed the stale nvbugs/6427411 waiver and SKIP marker for TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2].
  • The change is limited to one waives.txt entry.
  • The test-list format remains consistent.
  • No other tests, bug references, or public entities changed.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed one entry from tests/integration/test_lists/waives.txt.
  • The affected test will run without the obsolete waiver.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f03ee1b4-3c6f-4391-97ad-521fdd0091f6

📥 Commits

Reviewing files that changed from the base of the PR and between 8e588da and f0380c6.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Walkthrough

The integration waiver list removes the SKIP entry for the Llama 3.1 8B Instruct asymmetric context/parallelism test configuration.

Changes

Cohort / File(s) Summary
Waiver list update
tests/integration/test_lists/waives.txt
Removes the waiver and nvbugs reference for test_ctx_pp_gen_tp_asymmetric with GSM8K-gen_tp=1-ctx_pp=2.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: ci: full pre-merge approved

Suggested reviewers: crazydemo, brnguyen2, mlefeb01

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the root cause, the stale waiver removal, scope limits, test plan, and bug reference.
Title check ✅ Passed The title identifies the bug, fix type, and removal of the stale waiver, but it ends with an ellipsis and an incomplete test reference.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@BowenFu BowenFu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — removes a stale skip; the under-populated-buffer regression it guarded was already reverted (#16163). No product code.

@trtllm-agent
trtllm-agent force-pushed the repair-bot-bug6435097 branch from 261fd97 to 384414e Compare July 21, 2026 13:41

@mzweilz mzweilz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the unwaived test passes.

@fredricz-20070104 fredricz-20070104 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary - Approve

Reviewed the full diff; no blocking or major issues found.

Minor, non-blocking notes:

  • tests/integration/test_lists/waives.txt: Sibling waiver for the same bug id 6427411 left in place

Automated review by NVCortex Lite, run by @fredricz-20070104.

@trtllm-agent
trtllm-agent force-pushed the repair-bot-bug6435097 branch from 384414e to 5878223 Compare August 4, 2026 07:03
@trtllm-agent
trtllm-agent requested a review from a team as a code owner August 4, 2026 07:03
The TorchSampler IndexError described in nvbug 6435097 was introduced by
PR NVIDIA#15920 ("Move greedy stop checks to host") and cleanly reverted by
PR NVIDIA#16163 (commit 9a8ec05). PR NVIDIA#16163 is already present at HEAD, so
the underlying code bug is fixed.

The waiver at nvbugs/6427411 for
test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2] was added by
PRs NVIDIA#16103 / NVIDIA#16105 / NVIDIA#16127 before the revert landed and was not
cleaned up afterward.

Verified locally on this HEAD (e523b43):
  pytest tests/integration/defs/accuracy/test_disaggregated_serving.py::\
    TestLlama3_1_8BInstruct::test_ctx_pp_gen_tp_asymmetric[GSM8K-gen_tp=1-ctx_pp=2]
  -> PASSED, GSM8K accuracy = 73.465 (threshold 70.997).

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@trtllm-agent
trtllm-agent force-pushed the repair-bot-bug6435097 branch from 5878223 to f0380c6 Compare August 6, 2026 14:01
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants