Skip to content

[None][test] Add pure -Perf- stage exclusion in CBTS logic#16328

Open
yufeiwu-nv wants to merge 10 commits into
NVIDIA:mainfrom
yufeiwu-nv:cbts_null_diff
Open

[None][test] Add pure -Perf- stage exclusion in CBTS logic#16328
yufeiwu-nv wants to merge 10 commits into
NVIDIA:mainfrom
yufeiwu-nv:cbts_null_diff

Conversation

@yufeiwu-nv

@yufeiwu-nv yufeiwu-nv commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Introduced a new function to identify pure -Perf- stages and updated the main processing logic to exclude these stages from the affected stages list.

Currently, whether to prune --Perf- Stage is aligned.

Enhanced logging to include details about excluded stages for better diagnostics in Jenkins console output.

Signed-off-by: yufeiwu-nv 230315618+yufeiwu-nv@users.noreply.github.com

Summary by CodeRabbit

  • Bug Fixes
    • Improved affected-stage detection by excluding stages that are exclusively performance-related when they do not require testing.
    • Updated diagnostic output to clearly identify performance stages excluded from the results.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…#16170)

Updated the logic in the Selector class to provide clearer reasons when scopes cannot be combined. The new implementation distinguishes between forced fallbacks and actionable scopes, enhancing the feedback provided during selection failures.

Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
@yufeiwu-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

Introduced a new function to identify pure `-Perf-` stages and updated the main processing logic to exclude these stages from the affected stages list. Enhanced logging to include details about excluded stages for better diagnostics in Jenkins console output.

Signed-off-by: yufeiwu-nv <230315618+yufeiwu-nv@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 77b902d5-1171-49b1-a161-5d4cdcfeb93b

📥 Commits

Reviewing files that changed from the base of the PR and between 5603308 and eec6b5d.

📒 Files selected for processing (1)
  • jenkins/scripts/cbts/main.py

📝 Walkthrough

Walkthrough

Changes

CBTS performance-stage filtering

Layer / File(s) Summary
Pure performance stage filtering
jenkins/scripts/cbts/main.py
Adds detection for -Perf- stages, excluding -PerfSanity-, and removes pure performance stages from result.affected_stages.
Exclusion diagnostic reporting
jenkins/scripts/cbts/main.py
Passes excluded stages to _log_decision_to_stderr and reports their count and names when present.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mlefeb01, dpitman-nvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and matches the main change: excluding pure -Perf- stages from CBTS logic.
Description check ✅ Passed The description explains the change and checklist, but it omits the required Test Coverage section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58977 [ run ] triggered by Bot. Commit: 0d8b590 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58977 [ run ] completed with state SUCCESS. Commit: 0d8b590
/LLM/main/L0_MergeRequest_PR pipeline #47508 completed with status: 'SUCCESS'

CI Report

Link to invocation

@crazydemo crazydemo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants