Skip to content

[https://nvbugs/6435642][fix] avoid isinstance(MpiPoolSession) crash under session-reuse test infra #16438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrGeva wants to merge 1 commit into from
Closed

[https://nvbugs/6435642][fix] avoid isinstance(MpiPoolSession) crash under session-reuse test infra #16438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tensorrt_llm/executor/proxy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,14 @@ def mpi_done_callback(future: concurrent.futures.Future):
raise RuntimeError(
"Executor worker returned error") from ready_signal

if isinstance(self.mpi_session, MpiPoolSession) and len(status) == 3:
# Re-import MpiPoolSession from its origin module rather than using the
# module-level name above: test infra (tests/test_common/session_reuse.py)
# monkeypatches this module's ``MpiPoolSession`` attribute to a pool-reuse
# factory function for bare LLM(...) tests, and isinstance() against a
# non-type raises TypeError.
from ..llmapi.mpi_session import MpiPoolSession as _MpiPoolSessionCls
if isinstance(self.mpi_session,
_MpiPoolSessionCls) and len(status) == 3:
worker_process_identities: List[WorkerProcessIdentity] = status[2]
self._worker_process_monitor.register(worker_process_identities)

Expand Down
Loading