Skip to content

[None][infra] Waive 1 failed cases for main in pre-merge 47847#16443

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260715-164414
Jul 15, 2026
Merged

[None][infra] Waive 1 failed cases for main in pre-merge 47847#16443
2ez4bz merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260715-164414

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @2ez4bz)
Target branch: main
Bug(s): 6462303

Waive entries added

kv_cache/test_kv_cache_v2_scheduler.py::TestKVCacheV2Llama::test_eviction_with_block_reuse SKIP (https://nvbugs/6462303)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Summary by CodeRabbit

  • Tests
    • Added an integration test waiver for a KV cache scheduler eviction scenario with block reuse.
    • The scenario is currently skipped and linked to tracking issue 6462303.

Bug(s): 6462303
Requested by: @2ez4bz

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@2ez4bz

2ez4bz commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

/bot skip --comment "Waive test to unblock CI"

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a SKIP waiver for TestKVCacheV2Llama::test_eviction_with_block_reuse, linked to NVBUG 6462303.

Changes

Integration test waiver

Layer / File(s) Summary
Add KV cache test waiver
tests/integration/test_lists/waives.txt
Adds a SKIP entry for the block-reuse eviction test and references NVBUG 6462303.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: tensorrt-cicd, chienchunhung, kaiyux

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is on-topic but does not follow the required template sections for Description, Test Coverage, and PR Checklist. Add the missing template sections and briefly explain the issue, the waiver change, relevant tests, and checklist confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific, correctly formatted, and matches the waiver change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

381-381: 📐 Maintainability & Code Quality | 🔵 Trivial

Track removal of this waiver as a follow-up.

Coverage is insufficient while kv_cache/test_kv_cache_v2_scheduler.py::TestKVCacheV2Llama::test_eviction_with_block_reuse remains skipped. After NVBUG 6462303 is fixed, remove this entry from tests/integration/test_lists/waives.txt.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/integration/test_lists/waives.txt` at line 381, Track NVBUG 6462303 for
follow-up by removing the waiver entry for
TestKVCacheV2Llama::test_eviction_with_block_reuse from waives.txt once the
underlying issue is fixed, so the test runs and coverage is restored.

Source: Path instructions

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 381: Add the repository-standard NVIDIA copyright header with the current
year at the beginning of tests/integration/test_lists/waives.txt, using comment
lines so the waiver parser continues to ignore it.

---

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 381: Track NVBUG 6462303 for follow-up by removing the waiver entry for
TestKVCacheV2Llama::test_eviction_with_block_reuse from waives.txt once the
underlying issue is fixed, so the test runs and coverage is restored.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 41f235dd-de85-4dbf-9beb-abe43a7bbc22

📥 Commits

Reviewing files that changed from the base of the PR and between 0623958 and fbe9af3.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59481 [ skip ] triggered by Bot. Commit: fbe9af3 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #59481 [ skip ] completed with state SUCCESS. Commit: fbe9af3
Skipping testing for commit fbe9af3

Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) July 15, 2026 17:10
@2ez4bz
2ez4bz merged commit 495611c into NVIDIA:main Jul 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants