[None][infra] Waive 1 failed cases for main in pre-merge 47847#16443
Conversation
Bug(s): 6462303 Requested by: @2ez4bz Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Waive test to unblock CI" |
📝 WalkthroughWalkthroughAdds a ChangesIntegration test waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
381-381: 📐 Maintainability & Code Quality | 🔵 TrivialTrack removal of this waiver as a follow-up.
Coverage is insufficient while
kv_cache/test_kv_cache_v2_scheduler.py::TestKVCacheV2Llama::test_eviction_with_block_reuseremains skipped. After NVBUG 6462303 is fixed, remove this entry fromtests/integration/test_lists/waives.txt.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 381, Track NVBUG 6462303 for follow-up by removing the waiver entry for TestKVCacheV2Llama::test_eviction_with_block_reuse from waives.txt once the underlying issue is fixed, so the test runs and coverage is restored.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 381: Add the repository-standard NVIDIA copyright header with the current
year at the beginning of tests/integration/test_lists/waives.txt, using comment
lines so the waiver parser continues to ignore it.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 381: Track NVBUG 6462303 for follow-up by removing the waiver entry for
TestKVCacheV2Llama::test_eviction_with_block_reuse from waives.txt once the
underlying issue is fixed, so the test runs and coverage is restored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 41f235dd-de85-4dbf-9beb-abe43a7bbc22
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #59481 [ skip ] triggered by Bot. Commit: |
|
PR_Github #59481 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @2ez4bz)
Target branch:
mainBug(s): 6462303
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit