[https://nvbugs/6463831][fix] Replace isinstance(self.mpi_session, MpiPoolSession) with `not…#16491
Closed
trtllm-agent wants to merge 1 commit into
Closed
[https://nvbugs/6463831][fix] Replace isinstance(self.mpi_session, MpiPoolSession) with `not…#16491trtllm-agent wants to merge 1 commit into
isinstance(self.mpi_session, MpiPoolSession) with `not…#16491trtllm-agent wants to merge 1 commit into
Conversation
… rebind
The session-reuse test infrastructure (tests/test_common/session_reuse.py)
monkey-patches the module-level MpiPoolSession symbol in
tensorrt_llm.executor.proxy with a factory function to enable pool reuse
across LLM instances. That breaks isinstance(self.mpi_session,
MpiPoolSession) in _start_executor_workers with:
TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union
Switch to the polymorphic MpiSession.is_comm_session() predicate. It is a
method call on the instance, so it does not depend on the module-level
MpiPoolSession symbol staying bound to the class, and it composes with
the _ReusableSession wrapper's __getattr__ delegation. Negating it
selects the same set of local-pool sessions (MpiPoolSession and
subclasses) as the original isinstance check.
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe executor worker startup path now uses ChangesExecutor session detection
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
2 tasks
Collaborator
|
Close as fix has been submitted already |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isinstance(self.mpi_session, MpiPoolSession)withnot self.mpi_session.is_comm_session(), the polymorphic predicate already defined on MpiSession base class — immune to module-level symbol rebinding, matches the same session set.Test plan
Links
Summary by CodeRabbit