-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[TRTLLM-13579][feat] BREAKING: Support BCG in Prefill #16609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GuanhuaWang2001
wants to merge
19
commits into
NVIDIA:main
Choose a base branch
from
GuanhuaWang2001:feature/bcg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
0ae1f5c
BCG V1
GuanhuaWang2001 285a75a
bcg v2, support more model, fix adp bug and dsv4 bug
GuanhuaWang2001 043bee6
[07/23/14:03] share BCG pool across segments
GuanhuaWang2001 367adcc
[07/23/16:37] benchmark DSV4 1P1D AAAgent with BCG
GuanhuaWang2001 9a3b356
chore: checkpoint MLA epilogue fusion draft
GuanhuaWang2001 e1992b4
[07/24/20:09] refactor DSv4 BCG epilogue fusion
GuanhuaWang2001 f6c937e
fix bcg and epilogue
GuanhuaWang2001 9514e3d
rename some var name to make mla more clear
GuanhuaWang2001 cf7bfae
[None][test] add focused BCG accuracy coverage
GuanhuaWang2001 3e5aa46
[None][chore] apply pre-commit fixes to BCG changes
GuanhuaWang2001 8ce084f
[None][fix] preserve PCG behavior with breakable CUDA graphs
GuanhuaWang2001 7da1cfc
[None][test] remove DeepSeek V4 BCG accuracy tests
GuanhuaWang2001 a22a553
[None][fix] repair BCG tests after rebase
GuanhuaWang2001 d984f98
[None][fix] avoid implicit legacy PCG bucket conflicts
GuanhuaWang2001 fae1d66
[None][fix] restrict eager graph captured values
GuanhuaWang2001 3b78448
reorganize tests
GuanhuaWang2001 1d4f0ee
[None][test] provide valid prepared graph inputs
GuanhuaWang2001 17d17e1
[None][fix] keep prefill warmup ranks aligned
GuanhuaWang2001 baa6174
[None][fix] simplify breakable CUDA graph helpers
GuanhuaWang2001 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why gdn need to separate PCG and DCG but attention don't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i made mistakes. gdn dont need to separate PCG and BCG