[None][infra] Waive 12 failed cases for main in post-merge 2889 - #17407
Conversation
Bug(s): 6572800, 6572835, 6572843 Requested by: @mzweilz Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "waive only" |
WalkthroughThe integration waiver list now skips selected visual-generation accuracy tests, one GB300 DeepSeek-R1 FP4 disaggregated performance test, and one single-GPU MegaMoE CUTEDSL test. Each entry references an NVBug issue. ChangesIntegration test waivers
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 133-148: Add the repository-standard NVIDIA copyright header at
the top of waives.txt, using the waiver-list parser’s accepted comment syntax
and setting the copyright year to 2026. Preserve all existing waiver entries
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c01298a2-c929-432a-a2d4-33fafc077a48
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #64547 [ skip ] triggered by Bot. Commit: |
|
PR_Github #64547 [ skip ] completed with state |
brnguyen2
left a comment
There was a problem hiding this comment.
Approving — the comments below are optional touch-ups, not blockers.
Verified the 12 entries: test IDs, params, and file paths all resolve against the tests on disk (e.g. flux1-nvfp4/flux2-nvfp4 from the FLUX_MODEL_SPECS×FLUX_FEATURE_PROFILES cross product), no duplicates, and the file stays sorted.
One thing worth a second look before merging: 10 of the 12 are visual_gen *_accuracy_against_golden cases failing in the same post-merge run under a single bug, and per that bug they are first-time failures with an identified first-bad commit — that pattern reads more like one regression than 10 independent flakes. Waiving them all removes the signal; it would be good to make sure the owner of the suspect commit is looped in so the waivers don't sit indefinitely.
…IA#17407) Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6572800, 6572835, 6572843
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
tests/integration/test_lists/waives.txt.