Skip to content

[None][fix] remove duplicated test - #17579

Merged
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/dedupe_test
Aug 12, 2026
Merged

[None][fix] remove duplicated test#17579
tburt-nv merged 1 commit into
NVIDIA:mainfrom
tburt-nv:user/tburt/dedupe_test

Conversation

@tburt-nv

@tburt-nv tburt-nv commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

#17283 rebased on #17351 and incorrectly resolved a merge conflict, duplicating a test entry in the test lists.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv
tburt-nv requested a review from a team as a code owner August 12, 2026 19:29
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: df62c01f-8424-4c59-a04a-9c4343005f1d

📥 Commits

Reviewing files that changed from the base of the PR and between 3612c80 and b4d4f9b.

📒 Files selected for processing (1)
  • tests/integration/test_lists/qa/llm_function_core.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/qa/llm_function_core.txt

Walkthrough

The integration LLM test listing removes a duplicate unittest/disaggregated/test_openai_disagg_server.py entry.

Changes

LLM test listing

Layer / File(s) Summary
Remove duplicate test entry
tests/integration/test_lists/qa/llm_function_core.txt
The test list removes the duplicate disaggregated OpenAI server test path.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: stanleysun639

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title follows the required format and clearly states that the pull request removes a duplicated test.
Description check ✅ Passed The description explains the cause and fix, but it does not provide specific test coverage details.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tburt-nv
tburt-nv merged commit 751a6d4 into NVIDIA:main Aug 12, 2026
14 of 17 checks passed
@tburt-nv
tburt-nv requested a review from SimengLiu-nv August 12, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant