Skip to content

[BIO-303] support LoRA in evo2 mbridge#1550

Merged
balvisio merged 3 commits intomainfrom
dev/ba/BIO-303-support-lora-in-evo2-mbridge
Apr 23, 2026
Merged

[BIO-303] support LoRA in evo2 mbridge#1550
balvisio merged 3 commits intomainfrom
dev/ba/BIO-303-support-lora-in-evo2-mbridge

Conversation

@balvisio
Copy link
Copy Markdown
Collaborator

Description

Usage

TODO: Add code snippet

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe):

CI Pipeline Configuration

Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run.

  • ciflow:skip - Skip all CI tests for this PR
  • ciflow:notebooks - Run Jupyter notebooks execution tests
  • ciflow:slow - Run slow single GPU integration tests marked as @pytest.mark.slow
  • ciflow:all - Run all tests (unit tests, slow tests, and notebooks). This label can be used to enforce running all framework tests.
  • ciflow:all-recipes - Run tests for all recipes (under bionemo-recipes). This label can be used to enforce running tests for all recipes.

Unit tests marked as @pytest.mark.multi_gpu or @pytest.mark.distributed are not run in the PR pipeline.

For more details, see CONTRIBUTING

Note

By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage.

Authorizing CI Runs

We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.

  • If a pull request is opened by a trusted user and contains only trusted changes, the pull request's code will
    automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
  • If a pull request is opened by an untrusted user or contains untrusted changes, an NVIDIA org member must leave an
    /ok to test comment on the pull request to trigger CI. This will need to be done for each new commit.

Triggering Code Rabbit AI Review

To trigger a code review from code rabbit, comment on a pull request with one of these commands:

See https://docs.coderabbit.ai/reference/review-commands for a full list of commands.

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d3e73b83-54be-4087-b21a-f8ba9ded6da8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev/ba/BIO-303-support-lora-in-evo2-mbridge

Comment @coderabbitai help to get the list of available commands and usage tips.

@balvisio balvisio force-pushed the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch 5 times, most recently from 2b8e0ea to 306f0e4 Compare April 16, 2026 14:27
@balvisio balvisio changed the title [BIO-303] support lora in evo2 mbridge [BIO-303] support LoRA in evo2 mbridge Apr 16, 2026
@balvisio balvisio force-pushed the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch from 306f0e4 to b1e54ff Compare April 17, 2026 21:40
Copy link
Copy Markdown
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the biggest gap I see is around documenting how to ship and ingest a LORA checkpoint. Is it separate from the rest of the model or is it a combined checkpoint with everything in it including the original weights? I'd say call this out in the docs etc so people know what to expect. The other gap I see is the head swap use case which is pretty common for fine tuning. For now you could mention theoretically how you would do it. I think it would end up being a new model type or a new training script that has the desired structure in code, then I'm not 100% how to load the existing weights into it while handling the missing new head weight or changed shape gracefully, maybe it's writing a new checkpoint converter that does the necessary weight mugging? Anyways calling out in the readme how that would be done will probably save us support time long term.

Thanks!

Signed-off-by: Bruno Alvisio <balvisio@nvidia.com>
@balvisio balvisio force-pushed the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch from b1e54ff to 37ee6ef Compare April 20, 2026 11:17
Signed-off-by: Bruno Alvisio <balvisio@nvidia.com>
@balvisio balvisio force-pushed the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch 5 times, most recently from affb95a to 66da18e Compare April 21, 2026 09:55
Signed-off-by: Bruno Alvisio <balvisio@nvidia.com>
@balvisio balvisio force-pushed the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch from 66da18e to 7775b41 Compare April 21, 2026 10:59
@balvisio balvisio added this pull request to the merge queue Apr 23, 2026
@balvisio
Copy link
Copy Markdown
Collaborator Author

@jstjohn I added the documentation on how LoRA adapters are saved and how to use them along with the base checkpoint for inference. For the modification of the model head I will add as part of the next PR that contains a LoRA focused Jupyter notebook.

Merged via the queue into main with commit 1263f64 Apr 23, 2026
22 checks passed
@balvisio balvisio deleted the dev/ba/BIO-303-support-lora-in-evo2-mbridge branch April 23, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants