Skip to content

Conversation

@davebayer
Copy link
Contributor

All supported compilers support aligned allocations. Let's enable them.

@davebayer davebayer requested a review from a team as a code owner December 22, 2025 15:41
@davebayer davebayer requested a review from wmaxey December 22, 2025 15:41
@github-project-automation github-project-automation bot moved this to Todo in CCCL Dec 22, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Dec 22, 2025
@davebayer davebayer force-pushed the enable_aligned_allocations branch 2 times, most recently from 35a2f84 to bd1a551 Compare December 22, 2025 15:52
@github-actions

This comment has been minimized.

@davebayer davebayer force-pushed the enable_aligned_allocations branch from bd1a551 to 68f5360 Compare January 5, 2026 12:41
@davebayer davebayer requested a review from miscco January 5, 2026 12:46
Comment on lines +63 to 67
_CCCL_API void __cccl_operator_delete(_Args... __args)
{
// Those builtins are not usable on device and the tests crash when using them
#if defined(_CCCL_BUILTIN_OPERATOR_DELETE)
_CCCL_BUILTIN_OPERATOR_DELETE(__args...);
#else // ^^^ _CCCL_BUILTIN_OPERATOR_DELETE ^^^ / vvv !_CCCL_BUILTIN_OPERATOR_DELETE vvv
::operator delete(__args...);
#endif // !_CCCL_BUILTIN_OPERATOR_DELETE
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am highly sceptical that this works across our support matrix. Did you try CTK 12.5 and CTK 12.0?

@davebayer davebayer requested a review from a team as a code owner January 5, 2026 12:57
@davebayer davebayer force-pushed the enable_aligned_allocations branch from c95dbe6 to 68f5360 Compare January 5, 2026 13:11
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

🥳 CI Workflow Results

🟩 Finished in 3h 13m: Pass: 100%/91 | Total: 1d 17h | Max: 3h 13m | Hits: 84%/217088

See results here.

@davebayer davebayer self-assigned this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants