[BUG] use references for mdspan internal methods #7059
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 39m: Pass: 100%/91 | Total: 23h 42m | Max: 46m 34s | Hits: 94%/210325See results here. |
bernhardmgruber
approved these changes
Jan 2, 2026
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.2.x
git worktree add -d .worktree/backport-7059-to-branch/3.2.x origin/branch/3.2.x
cd .worktree/backport-7059-to-branch/3.2.x
git switch --create backport-7059-to-branch/3.2.x
git cherry-pick -x 8136b82468e0c17f4adda51717c63a53b57061dc |
Contributor
|
@fbusato If you’re able to fix the backport for branch/3.2.x, I’ll test it in RAFT and revert the changes I made to remove constexpr usage. |
Contributor
Author
|
yes, this is my intention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7057
Description
Refactor mdspan methods to use const references for temporary mapping objects to fix #7057