Repository navigation
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
c562cd6 to
5b1111d
Compare
A second invocation can fail before it creates its output directory. Reading summary.json from that directory can report a previous success. Print a failure summary when the current component run records it, while preserving the original exception for Python callers. Signed-off-by: Trent Nelson <trentn@nvidia.com>
5b1111d to
c6d5af2
Compare
melo-gonzo
left a comment
There was a problem hiding this comment.
Approving. The existing-directory check at examples/run_quickstarts.py:638-641 runs before this invocation writes anything, so stdout now stays empty in the case from #218. mkdir without exist_ok also turns a race between two runs into the same error. A component failure prints the summary from on_failure right after _write_json saves it. Both use the same json.dumps settings, which is why the new test can compare stdout with the file byte for byte.
Fixes #218.
Running the quickstart twice with the same output directory could make the second invocation print the first run's successful JSON before exiting with an error. The CLI now prints a failure summary only when the current invocation has written one. An existing output directory still produces an error on stderr and exit code 1. A component failure in a new directory still prints its persisted failure summary.
All 11 quickstart tests pass, including both failure cases. Two concurrent xRay CPU quickstarts targeting one directory produced one success and one failure with empty stdout. The changed-file hooks, mypy and lock checks passed.