Fix Iceberg REST compression defaults#15295
Conversation
Apply supported Parquet compression codecs directly to REST test tables because Iceberg 1.6.x does not honor catalog table defaults during table creation. Fixes NVIDIA#15274. Signed-off-by: Chong Gao <chongg@nvidia.com>
|
build |
Greptile SummaryThis PR fixes an Iceberg REST catalog test failure where Iceberg 1.6.x ignores catalog-level
Confidence Score: 5/5Safe to merge — targeted fix to test infrastructure replacing a broken catalog-level workaround with a per-table approach that works across all tested Iceberg versions. All GPU write tests route through _build_tblprops() or _BASE_TBLPROPS_SQL, both of which pick up the new codec properties. The removed env vars in spark-tests.sh are fully superseded by the table-level properties. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Fix Iceberg REST compression defaults" | Re-trigger Greptile |
|
build |
Fixes #15274.
Description
Iceberg REST catalog write tests can resolve the Parquet compression codec to
gzip, which is not supported by the GPU writer. The previous catalog-level fix is effective with Iceberg 1.9.x and 1.10.x, but Iceberg 1.6.x does not applytable-default.*properties when creating REST tables.This change sets
write.parquet.compression-codec=zstdandwrite.delete.parquet.compression-codec=zstddirectly on every REST test table. It also removes the version-dependent catalog defaults fromjenkins/spark-tests.shand documents the compatibility behavior.Validation:
test_insert_into_aqe[unpartitioned]passed.test_delete_aqe[unpartitioned]passed with copy-on-write and merge-on-read.python -m py_compile integration_tests/src/main/python/iceberg/__init__.pypassed.bash -n jenkins/spark-tests.shpassed.Checklists
Documentation
Testing
(
test_insert_into_aqe[unpartitioned]andtest_delete_aqe[unpartitioned])Performance