Skip to content

Skip another test that fails due to a polars bug - #23984

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/nightly
Sep 4, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
wence-:wence/fix/nightly

Conversation

@wence-

@wence- wence- commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

In #23969 we skipped some tests in Polars 1.39, since it has bugs. However, we didn't catch them all. Address that.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence-
wence- requested a review from a team as a code owner September 4, 2026 09:45
@wence-
wence- requested a review from nirandaperera September 4, 2026 09:45
@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6a266fec-d680-4640-88d6-cf7ec74b1449

📥 Commits

Reviewing files that changed from the base of the PR and between 953eff5 and 914969d.

📒 Files selected for processing (1)
  • python/cudf_polars/tests/expressions/test_agg.py

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated aggregation test coverage to skip incompatible Polars versions affected by a literal-handling issue.

Walkthrough

The groupby scalar max_by/min_by test now skips Polars versions before 1.39 and documents the Polars 1.38 literal-handling bug.

Changes

Polars test compatibility

Layer / File(s) Summary
Aggregation test version gate
python/cudf_polars/tests/expressions/test_agg.py
The test now excludes Polars versions before 1.39 and documents the Polars 1.38 literal-handling bug.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 91496

This change skips the affected aggregation test on unsupported Polars versions while retaining coverage on Polars 1.39 and later. It is ready to merge.

Suggested reviewers: mroeschke, matt711

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: skipping an additional test because of a Polars bug.
Description check ✅ Passed The description directly explains that the pull request extends existing test exclusions for Polars bugs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@wence- wence- added bug Something isn't working non-breaking Non-breaking change labels Sep 4, 2026
@wence-

wence- commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 0d9f19b into NVIDIA:main Sep 4, 2026
212 of 214 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Sep 4, 2026
@wence-
wence- deleted the wence/fix/nightly branch September 4, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants