-
Notifications
You must be signed in to change notification settings - Fork 104
Remove alpha specs from non-RAPIDS dependencies #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughRemoved prerelease suffixes (.dev0, a0) from upper-bound version constraints for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/merge |
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
|
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
conda/recipes/cuopt/recipe.yaml (1)
81-81: Update numpy upper bound constraint to<3.0for consistency.Line 81 contains
numpy >=1.23,<3.0a0with a pre-release upper bound indicator. All other recipe files (cuopt-server, mps-parser) and environment files use<3.0without thea0suffix. Update this constraint to<3.0to align with the rest of the codebase.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
conda/environments/all_cuda-129_arch-aarch64.yaml(3 hunks)conda/environments/all_cuda-129_arch-x86_64.yaml(3 hunks)conda/environments/all_cuda-130_arch-aarch64.yaml(3 hunks)conda/environments/all_cuda-130_arch-x86_64.yaml(3 hunks)conda/recipes/cuopt/recipe.yaml(2 hunks)dependencies.yaml(3 hunks)python/cuopt/pyproject.toml(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (5)
- python/cuopt/pyproject.toml
- conda/environments/all_cuda-129_arch-aarch64.yaml
- conda/environments/all_cuda-129_arch-x86_64.yaml
- dependencies.yaml
- conda/environments/all_cuda-130_arch-aarch64.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: wheel-build-cuopt-server / compute-matrix
- GitHub Check: wheel-build-cuopt-sh-client / 13.0.2, 3.10, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.12, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.10, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.13, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.12, amd64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.11, arm64, rockylinux8
- GitHub Check: wheel-build-cuopt-mps-parser / 13.0.2, 3.11, amd64, rockylinux8
🔇 Additional comments (2)
conda/environments/all_cuda-130_arch-x86_64.yaml (1)
19-19: LGTM! Pre-release suffixes correctly removed.The removal of pre-release suffixes from
cuda-python,numpy, andrapids-build-backendupper bounds is correct and aligns with the PR objectives. These changes prevent pip from treating pre-releases as acceptable when--preis not specified.Also applies to: 49-49, 61-61
conda/recipes/cuopt/recipe.yaml (1)
65-65: LGTM! Pre-release suffixes correctly removed.The removal of pre-release suffixes from
rapids-build-backendandcuda-pythonconstraints is correct and aligns with the PR objectives.Also applies to: 70-71, 93-94
|
🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
Description
This PR removes pre-release upper bound pinnings from non-RAPIDS dependencies.
The presence of pre-release indicators like
<...a0tells pip "pre-releases are OK, even if--prewas not passed to pip install." RAPIDS projects currently use such constraints in situations where it's not actually desirable to get pre-releases.xref: rapidsai/build-planning#144
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.