Skip to content

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Dec 9, 2025

This PR removes the CUDA_STATIC_RUNTIME option and always uses static linking for the CUDA runtime (cudart_static).

Changes

  • Remove CUDA_STATIC_RUNTIME option from cpp/CMakeLists.txt
  • Change rapids_cuda_init_runtime(USE_STATIC ${CUDA_STATIC_RUNTIME}) to rapids_cuda_init_runtime(USE_STATIC ON)
  • Remove set(CUDA_STATIC_RUNTIME ON) from Python CMakeLists.txt files

Motivation

Static linking embeds the CUDA runtime into binaries, eliminating runtime dependency on cuda-cudart conda packages and simplifying deployment.

Related

Summary by CodeRabbit

  • Chores
    • Removed the user-configurable CUDA static runtime option; CUDA runtime now always links statically.
    • Cleared commented/no-op directives related to CUDA static linking.
    • Removed explicit CUDA development runtime from host build requirements and removed corresponding runtime-suppression entries from package export lists.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

📝 Walkthrough

Walkthrough

Removed the CUDA_STATIC_RUNTIME CMake option and hard-coded static CUDA runtime linking (USE_STATIC ON) in CMake; removed commented/static-linking lines in wheel/build CMake files; conda recipes removed cuda-cudart-dev from host requirements and dropped cuda-cudart from ignore_run_exports/by_name.

Changes

Cohort / File(s) Summary
CMake: enforce static CUDA runtime
cpp/CMakeLists.txt
Removed public option CUDA_STATIC_RUNTIME; changed rapids_cuda_init_runtime(... USE_STATIC ${CUDA_STATIC_RUNTIME}) to USE_STATIC ON.
CMake: wheel/build cleanup
python/libcuopt/CMakeLists.txt, python/cuopt/cuopt/linear_programming/CMakeLists.txt
Removed set(CUDA_STATIC_RUNTIME ON) and related commented labels about statically linking dependencies in CUOPT_BUILD_WHEELS / wheel build blocks.
Conda: remove cuda-cudart-dev and run_exports suppression
conda/recipes/cuopt/recipe.yaml, conda/recipes/libcuopt/recipe.yaml
Removed cuda-cudart-dev from host requirements; removed cuda-cudart entries from ignore_run_exports/by_name across affected outputs (libmps-parser, libcuopt, libcuopt-tests).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'Use static linkage for CUDA runtime' directly and accurately summarizes the main change: enforcing static CUDA runtime linkage across CMakeLists.txt and conda recipe files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cca063 and 70f822d.

📒 Files selected for processing (2)
  • conda/recipes/cuopt/recipe.yaml
  • conda/recipes/libcuopt/recipe.yaml
💤 Files with no reviewable changes (2)
  • conda/recipes/cuopt/recipe.yaml
  • conda/recipes/libcuopt/recipe.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are missing changes to conda/recipes/*, and dependencies.yaml ( usage of nvidia-cudart )

@bdice bdice added breaking Introduces a breaking change improvement Improves an existing functionality labels Dec 10, 2025
@tmckayus tmckayus added this to the 26.02 milestone Dec 10, 2025
@github-actions
Copy link

🔔 Hi @anandhkb, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@rgsl888prabhu
Copy link
Collaborator

How much increase in library size should we expect ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants