-
Notifications
You must be signed in to change notification settings - Fork 104
Use static GTest #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use static GTest #729
Conversation
📝 WalkthroughWalkthroughRemoved gmock and gtest from multiple conda environment and recipe files, removed Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
💤 Files with no reviewable changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔔 Hi @anandhkb @bdice, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you! If this is an "epic" issue, then please add the "epic" label to this issue. |
Description
This switches cuOpt to fetch GTest with CPM and statically link it into the test executables. This removes the conda dependency on gtest and aligns with what we do in cuDF and other RAPIDS libraries.
Checklist
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.