dcgmprovider: drop unused moduleCleanup field (staticcheck U1000) - #693
Open
randomizedcoder wants to merge 1 commit into
Open
dcgmprovider: drop unused moduleCleanup field (staticcheck U1000)#693randomizedcoder wants to merge 1 commit into
randomizedcoder wants to merge 1 commit into
Conversation
internal/pkg/dcgmprovider/dcgm.go:55 Field is never read or assigned. Signed-off-by: randomizedcoder dave.seddon.ca@gmail.com <dave.seddon.ca@gmail.com>
randomizedcoder
added a commit
to randomizedcoder/dcgm-exporter
that referenced
this pull request
Jun 20, 2026
Map each finding addressed in the report to its upstream PR (NVIDIA/dcgm-exporter NVIDIA#681 NVIDIA#682 NVIDIA#683 NVIDIA#684 NVIDIA#685 NVIDIA#686 NVIDIA#687 NVIDIA#688 NVIDIA#689 NVIDIA#690 NVIDIA#691 NVIDIA#692 NVIDIA#693 NVIDIA#694). Signed-off-by: randomizedcoder dave.seddon.ca@gmail.com <dave.seddon.ca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: delete the unused
moduleCleanupfield from thedcgmProviderstruct.Why: dead code; nothing reads or assigns it. Confirmed by
grep -rn moduleCleanup internal/ pkg/ cmd/.How: remove the single line in
internal/pkg/dcgmprovider/dcgm.go:55.Found by: staticcheck 2026.1 (v0.7.0), rule U1000 — unused code (struct field never used).