Drop direct dependency on archived github.com/pkg/errors - #699
Closed
skartikey wants to merge 1 commit into
Closed
Conversation
github.com/pkg/errors was archived by its author in 2021. It was used in a
single place (tests/e2e/internal/framework/kube.go) via errors.Wrap. Replace
it with the standard library equivalent fmt.Errorf("...: %w", err), which the
same file already uses elsewhere, and run go mod tidy.
The package now only remains as an indirect dependency pulled in transitively
by helm.sh/helm/v3 (via mittwald/go-helm-client), which is outside this
repository's control.
Closes NVIDIA#526
Signed-off-by: skartikey <1942366+skartikey@users.noreply.github.com>
Collaborator
|
This is fixed in the latest version |
nccurry
added a commit
that referenced
this pull request
Jul 14, 2026
Filtered, squashed public import of the internal release snapshot. Source tag: 4.6.0-4.8.3 Source commit: 6e9668062deb36d7315f69731ad22eccd4019401 Source branch: origin/rel_exp_4_8_3 GitHub base: d5e5f51 Excluded paths: - .gitlab-ci.yml - .gitlab/** - .coderabbit.yaml - .greptile/** - internal/pkg/counters/llms_contract_test.go Attribution audit: carried work from #489, #510, #654, #658, #660, #663, #664, #665, #667, #671, #678, #687, #697, #699, and #704. Issues #641 and #703 are acknowledged through their corresponding implementers. Daphne's #655 remains directly attributed on GitHub main. Co-authored-by: Yang Tong <25810794+tongyangyeyue@users.noreply.github.com> Co-authored-by: Hairui Yang <hairuiyang@deeproute.ai> Co-authored-by: Aditya Singh <aditya.chouhan@neevcloud.com> Co-authored-by: Allen Zhou <loveinjavac@gmail.com> Co-authored-by: Yufeng Huang <91405051+Raid57@users.noreply.github.com> Co-authored-by: Rocker Zhang <zhang.rocker.liyuan@gmail.com> Co-authored-by: Swati Gupta <swatig@nvidia.com> Co-authored-by: Asutosh Panda <asutosh.pda@gmail.com> Co-authored-by: Shravya Vorugallu <shravyavorugallu@gmail.com> Co-authored-by: randomizedcoder <64496590+randomizedcoder@users.noreply.github.com> Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com> Co-authored-by: Dave Young <dave.andrew.young@gmail.com> Co-authored-by: rvatkar <263779040+rvatkar@users.noreply.github.com> Co-authored-by: dshaiknvidia <152336361+dshaiknvidia@users.noreply.github.com> Signed-off-by: Nick Curry <ncurry@nvidia.com>
nccurry
added a commit
that referenced
this pull request
Jul 15, 2026
Filtered, squashed public import of the internal release snapshot. Source tag: 4.6.0-4.8.3 Source commit: 6e9668062deb36d7315f69731ad22eccd4019401 Source branch: origin/rel_exp_4_8_3 GitHub base: d5e5f51 Excluded paths: - .gitlab-ci.yml - .gitlab/** - .coderabbit.yaml - .greptile/** - internal/pkg/counters/llms_contract_test.go Attribution audit: carried work from #489, #510, #654, #658, #660, #663, #664, #665, #667, #671, #678, #687, #697, #699, and #704. Issues #641 and #703 are acknowledged through their corresponding implementers. Daphne's #655 remains directly attributed on GitHub main. Signed-off-by: Nick Curry <ncurry@nvidia.com> Co-authored-by: Yang Tong <25810794+tongyangyeyue@users.noreply.github.com> Co-authored-by: Hairui Yang <hairuiyang@deeproute.ai> Co-authored-by: Aditya Singh <aditya.chouhan@neevcloud.com> Co-authored-by: Allen Zhou <loveinjavac@gmail.com> Co-authored-by: Yufeng Huang <91405051+Raid57@users.noreply.github.com> Co-authored-by: Rocker Zhang <zhang.rocker.liyuan@gmail.com> Co-authored-by: Swati Gupta <swatig@nvidia.com> Co-authored-by: Asutosh Panda <asutosh.pda@gmail.com> Co-authored-by: Shravya Vorugallu <shravyavorugallu@gmail.com> Co-authored-by: randomizedcoder <64496590+randomizedcoder@users.noreply.github.com> Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com> Co-authored-by: Dave Young <dave.andrew.young@gmail.com> Co-authored-by: rvatkar <263779040+rvatkar@users.noreply.github.com> Co-authored-by: dshaiknvidia <152336361+dshaiknvidia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/pkg/errors was archived by its author in 2021. It was used in a single place (tests/e2e/internal/framework/kube.go) via errors.Wrap. Replace it with the standard library equivalent fmt.Errorf("...: %w", err), which the same file already uses elsewhere, and run go mod tidy.
The package now only remains as an indirect dependency pulled in transitively by helm.sh/helm/v3 (via mittwald/go-helm-client), which is outside this repository's control.
Closes #526