Skip to content

Conversation

@ohemelaar-dinum
Copy link

Description

This missing namespace prevents the operator from being deployed with argocd and helmfile in some cases. ServiceAccounts are a namespaced resource so it's best to always specify it.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tariq1890
Copy link
Contributor

Thanks for the contribution @ohemelaar-dinum ! Can you enable signoff in your commit to pass the DCO check?

This missing namespace prevents the operator from being deployed with argocd and helmfile in some cases

Signed-off-by: Oscar Hemelaar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants