Clean up unused variables in get_kvcache_metadata_buffer#371
Clean up unused variables in get_kvcache_metadata_buffer#371gameofdimension wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Removed unused variable assignments for tensor data types and buffer sizes.
Greptile SummaryThis PR removes two genuinely unused statements from Confidence Score: 5/5Safe to merge — only dead code is removed with no behavioral change. Both removed statements were provably unused: the dtype expression had no left-hand side assignment and was never referenced, and No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["get_kvcache_metadata_buffer(hstu_config, kvcache_config)"] --> B["Compute max_new_history_seqlen"]
B --> C["Compute max_num_pages_per_seq"]
C --> D["~~dtype ternary (removed)~~"]
C --> E["~~max_host_kv_buffer_size (removed)~~"]
C --> F["Allocate paged_indices_buffer"]
F --> G["Allocate page_indptr_buffer"]
G --> H["Allocate last_page_lens_buffer"]
H --> I["Allocate batch_indices_buffer"]
I --> J["Allocate position_buffer"]
J --> K["Allocate total_history_offsets_buffer"]
K --> L["Return KVCacheMetadata"]
style D stroke-dasharray: 5 5,color:#999
style E stroke-dasharray: 5 5,color:#999
Reviews (1): Last reviewed commit: "Clean up unused variables in get_kvcache..." | Re-trigger Greptile |
Removed unused variable assignments for tensor data types and buffer sizes.
Description
Checklist