Skip to content

TAO Toolkit: add 2 missing skills to catalog (paidf-anomalygen, tao-run-on-docker)#318

Merged
mosheabr merged 2 commits into
NVIDIA:mainfrom
christinayyw:chore/tao-add-2-missing-skills
Jul 24, 2026
Merged

TAO Toolkit: add 2 missing skills to catalog (paidf-anomalygen, tao-run-on-docker)#318
mosheabr merged 2 commits into
NVIDIA:mainfrom
christinayyw:chore/tao-add-2-missing-skills

Conversation

@christinayyw

Copy link
Copy Markdown
Contributor

Two TAO skills exist in the source repo (NVIDIA-TAO/tao-skills-bank) but were never listed in components.d/tao-toolkit.yml, so the catalog sync never picked them up:

  • skills/data/paidf-anomalygen/paidf-anomalygen
  • skills/platform/tao-run-on-docker/tao-run-on-docker

Both are present, signed (skill.oms.sig), and carded (skill-card.md) in the source. This adds their catalog entries so they sync like the other 56 TAO Toolkit skills.

🤖 Generated with Claude Code

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christinayyw — good catch on the two un-listed skills. The yml structure is correct (right paths, correct sections, no catalog_dir collisions). paidf-anomalygen is fully ready at source (SKILL.md + skill.oms.sig + skill-card.md + evals). Two things to fix before merge:

  1. DCO sign-off is failing. Commit 63430864 has no Signed-off-by: trailer. Fix:

    git rebase --signoff origin/main && git push --force-with-lease
    
  2. tao-run-on-docker isn't fully signed at source yet. In NVIDIA-TAO/tao-skills-bank, skills/platform/tao-run-on-docker/ currently has only SKILL.md + evals/ — it's missing skill.oms.sig, skill-card.md, and BENCHMARK.md (compare tao-run-on-brev, which has all of them). Without the signature, the sync's enforcement will drop it on every run. Please run /nvskills-ci on that skill in the source repo to generate the sig + card, then it's good.

    Heads-up: the content-integrity CI check here is green, but that's expected — it only validates skills already present in the catalog, not source artifacts for a skill that hasn't synced yet. So it won't catch this gap.

paidf-anomalygen is ready to go — once DCO is signed and tao-run-on-docker is signed/carded at source, this is good to merge. (If you'd rather land paidf-anomalygen now and do tao-run-on-docker in a follow-up, I'm happy to split it — just say the word.)

@christinayyw
christinayyw force-pushed the chore/tao-add-2-missing-skills branch from 6343086 to 6f4247f Compare July 7, 2026 13:14
@christinayyw
christinayyw force-pushed the chore/tao-add-2-missing-skills branch from 6f4247f to 6b0704d Compare July 7, 2026 13:23
Signed-off-by: Christina Wang <77945617+christinayyw@users.noreply.github.com>
Signed-off-by: Christina Wang <77945617+christinayyw@users.noreply.github.com>
@christinayyw
christinayyw requested a review from jasonnvidia as a code owner July 8, 2026 01:40
@mosheabr

mosheabr commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Re-checked after your updates — thanks for the DCO fix and the repo-rename catch (verified NVIDIA-TAO/tao-skill-bank resolves).

Status: tao-run-on-docker is still unsigned at sourceskills/platform/tao-run-on-docker/ has only SKILL.md + evals/; no skill.oms.sig, skill-card.md, or BENCHMARK.md. That's the one remaining blocker (the sync would drop it on every run). paidf-anomalygen remains fully ready.

Standing offer from my earlier review: happy to split — drop tao-run-on-docker from this PR, merge paidf-anomalygen + the repo rename today, and add tao-run-on-docker in a follow-up once /nvskills-ci has signed it. Just say the word (or push the change and I'll re-review same day). If you hit any trouble with the signing run, tell me and I'll help debug.

@christinayyw

Copy link
Copy Markdown
Contributor Author

@mosheabr — the remaining blocker is resolved. tao-run-on-docker is now fully signed at source: NVIDIA-TAO/tao-skill-bank PR #64 merged (07-23), and skills/platform/tao-run-on-docker/ on main now has skill.oms.sig + skill-card.md + BENCHMARK.md: https://github.com/NVIDIA-TAO/tao-skill-bank/tree/main/skills/platform/tao-run-on-docker

could you help with the approval and get this MR merged?

@christinayyw
christinayyw requested a review from mosheabr July 24, 2026 18:53

@mosheabr mosheabr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed — both items from my earlier review are resolved: DCO is signed on both commits, and tao-run-on-docker now carries skill.oms.sig + skill-card.md + BENCHMARK (verdict PASS, Tier-3 populated) at source. yml structure, paths, and affiliation all check out. Approving — thanks @christinayyw. The two skills will sync on the next run.

@mosheabr
mosheabr merged commit 81e5db4 into NVIDIA:main Jul 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants