ci: require nvskills status for skill changes#372
Open
yashrajp22 wants to merge 4 commits into
Open
Conversation
yashrajp22
requested review from
jasonnvidia,
mosheabr and
sayalinvidia
as code owners
July 21, 2026 09:28
mosheabr
requested changes
Jul 21, 2026
mosheabr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @yashrajp22 — this closes a real gap and the overall shape is right. A few things before it can land:
Blockers
- DCO is failing — please
git rebase --signoff origin/main && git push --force-with-lease. - The guard needs to exempt the
automated/sync-skillsbot PRs (same pattern as the DCO/authors checks). Sync PRs touchskills/**with content signed in the source repos, so their head SHAs never carry anNVSkills CIstatus — as written this fails every daily sync PR.
Design
- The
status:trigger won't clear a red check on the PR:status-event runs execute against the default branch, so the new check run doesn't attach to the PR head SHA. Authors would need a manual re-run after/nvskills-cisucceeds. Consider having the NVSkills CI pipeline refresh the check itself, or aworkflow_run-based re-check. - Please drop the
paths:filter on thepull_requesttrigger. Once this check is required in branch protection, PRs that don't touch watched paths (e.g.components.d/onboarding PRs) would never report the check and sit at "Expected" forever. The job already self-skips via the files API, so it's safe to run on every PR.
Minor
- The
pushbranch of the guard'sifis unreachable (the caller only forwards signature pushes, which the guard excludes) — can be removed. - The failure message should note that
/nvskills-cionly works on branches in NVIDIA/skills, not forks, so fork authors know to move their branch rather than re-commenting.
Happy to re-review once updated.
yashrajp22
force-pushed
the
yashraj/require-nvskills-status-for-skills
branch
2 times, most recently
from
July 21, 2026 19:46
f69c055 to
cb798b4
Compare
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
Signed-off-by: yashrajbasav <yashrajbasav@nvidia.com>
yashrajp22
force-pushed
the
yashraj/require-nvskills-status-for-skills
branch
from
July 27, 2026 08:33
cb798b4 to
b04f8b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NVSkills CIstatus.skills/,team-skills/,rules/team-rules/, andplugins/./nvskills-cidispatch flow unchanged.Validation
.github/workflows/team-request.ymlas YAMLbash -non the inline guard scriptgit diff --check