Repository navigation
ci: run the unit and e2e tests on windows too - #273
Merged
Merged
Conversation
Exeloo
marked this pull request as ready for review
November 11, 2026 17:41
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 17:54
93fc51c to
1bcb2e7
Compare
This was referenced Nov 11, 2026
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 18:01
1bcb2e7 to
11f7fe8
Compare
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 18:59
11f7fe8 to
0edf585
Compare
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 19:37
0edf585 to
cb382e8
Compare
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 19:43
cb382e8 to
d8ebdbf
Compare
Exeloo
force-pushed
the
ci/windows-tests
branch
from
November 11, 2026 19:53
d8ebdbf to
b7919c9
Compare
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refs #123
Runs the unit and e2e tests on
windows-latesttoo, through the shared workflow's newextra-runnersinput:The existing
Tests / Unit testsandTests / End-to-end testschecks are unchanged; the new checks areTests / Unit tests (windows-latest)andTests / End-to-end tests (windows-latest).Stack (all PRs target
main, merge in this order): #274 (fixes the Windows failures) → this PR → #272. NanoForge-dev/actions has releasedextra-runnersunderv3. Until #274 merges, this PR also lists its commits.Merge danger
Door: two-way (revert is enough)
Blast radius: cli CI only. No package release, nothing deploys.
Follow-up issues
The first Windows run (43069392023) failed on two causes, both fixed in #274.
How do you test this PR?
pnpm run lint✓; pre-push hook:repo:build,repo:lint,repo:test:unit,repo:test:e2e✓ (Linux).(windows-latest)checks. Their results go in Paths are badly handled on Windows #123's retest.nfinside a project with a local CLI, so these runs don't exercise fix(cli): import the local cli command loader through a file url #272's fix directly.Quality gate