Repository navigation
build(deps): move the breakout example to the v3 cli and config - #288
Merged
Merged
Conversation
Exeloo
force-pushed
the
chore/breakout-cli-v3
branch
from
November 12, 2026 23:36
6362efd to
66549e6
Compare
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No linked issue. It's a follow-up found while reviewing #281.
examples/breakoutstill pinned@nanoforge-dev/configand@nanoforge-dev/cliat^2.3.0. #281 moves the editor's catalog to config^3.0.1, and cli 3.0.1 depends on config 3.0.1, so both move to^3.0.1.Is it compatible? This comes from reading the CLI's changelogs and the config source diff. Nothing was run on v3:
networkfield (defaultdedicated). Breakout's twonanoforge.config.tsfiles stay valid.nf install(No unit tests for ServerPluginHost and ProjectRegistry #263).nf startandnf builddon't change.How do you test this PR?
pnpm turbo build --filter=@nanoforge-dev/editor...pnpm lintnpx playwright test e2e/scene.spec.tsinapps/editor, withNANOFORGE_ENGINE/NANOFORGE_CLI: 5 passed.examples/is outside the pnpm workspace, and the e2e prep andpnpm examplelink breakout'snode_modulesfrom the engine'sexample/pong-network, which is still on cli/config 2.3. So the e2e run shows nothing broke, not that v3 works. Running breakout with cli and config 3.0.1 linked in, then Play, is still to do.Merge danger
Door: two-way (one file, two version ranges).
Blast radius: low. Only people who install breakout outside the repo get the new ranges. The file is not in the editor build or the workspace, so the editor that deploys on merge is unchanged.
Quality gate
Rounds run: 1. A single reviewer covered correctness, security and style.
Follow-up issues
None filed. Candidates, waiting on a decision:
example/pong-networkand the server-corepong-networkfixture still pin cli^2.3.0;NANOFORGE_CLI;Dockerfileinstalls@nanoforge-dev/cli@2.3.1.