Skip to content

build(deps): move the breakout example to the v3 cli and config - #288

Merged
Exeloo merged 1 commit into
mainfrom
chore/breakout-cli-v3
Nov 12, 2026
Merged

Exeloo merged 1 commit into
mainfrom
chore/breakout-cli-v3

Conversation

@Exeloo

@Exeloo Exeloo commented Nov 12, 2026

Copy link
Copy Markdown
Member

What does this PR do?

No linked issue. It's a follow-up found while reviewing #281.

examples/breakout still pinned @nanoforge-dev/config and @nanoforge-dev/cli at ^2.3.0. #281 moves the editor's catalog to config ^3.0.1, and cli 3.0.1 depends on config 3.0.1, so both move to ^3.0.1.

-    "@nanoforge-dev/cli": "^2.3.0",
-    "@nanoforge-dev/config": "^2.3.0",
+    "@nanoforge-dev/cli": "^3.0.1",
+    "@nanoforge-dev/config": "^3.0.1",

Is it compatible? This comes from reading the CLI's changelogs and the config source diff. Nothing was run on v3:

How do you test this PR?

  • Commands run, all exit 0:
    • pnpm turbo build --filter=@nanoforge-dev/editor...
    • pnpm lint
    • npx playwright test e2e/scene.spec.ts in apps/editor, with NANOFORGE_ENGINE/NANOFORGE_CLI: 5 passed.
  • Limit: none of this installs these ranges. examples/ is outside the pnpm workspace, and the e2e prep and pnpm example link breakout's node_modules from the engine's example/pong-network, which is still on cli/config 2.3. So the e2e run shows nothing broke, not that v3 works. Running breakout with cli and config 3.0.1 linked in, then Play, is still to do.

Merge danger

Door: two-way (one file, two version ranges).
Blast radius: low. Only people who install breakout outside the repo get the new ranges. The file is not in the editor build or the workspace, so the editor that deploys on merge is unchanged.

Quality gate

Check Result Notes
Docs N/A (no command, flag, config or setup step changes; the READMEs and AGENTS.md name no cli or config version) docs-writer
Correctness Pass 1 Minor: the e2e run doesn't install v3 (see the limit above)
Performance N/A (no runtime source changed)
Accessibility N/A (no UI changed)
Security Pass a version string; the e2e prep copies the file and runs no install
Style Pass lint: pass, commitlint: pass

Rounds run: 1. A single reviewer covered correctness, security and style.

Follow-up issues

None filed. Candidates, waiting on a decision:

  • the engine's example/pong-network and the server-core pong-network fixture still pin cli ^2.3.0;
  • the e2e breakout copy doesn't link NANOFORGE_CLI;
  • Dockerfile installs @nanoforge-dev/cli@2.3.1.

@Exeloo
Exeloo requested a review from Tchips46 as a code owner November 12, 2026 23:33
@Exeloo
Exeloo force-pushed the chore/breakout-cli-v3 branch from 6362efd to 66549e6 Compare November 12, 2026 23:36
@Exeloo
Exeloo merged commit fa95db3 into main Nov 12, 2026
12 checks passed
@Exeloo
Exeloo deleted the chore/breakout-cli-v3 branch November 12, 2026 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant