Replace Laminas Module Manager with a custom implementation. - #210
Conversation
This eliminates dependency on Laminas MVC and its dependencies.
|
@demiankatz I'd appreciate any feedback you might have considering we need to something similar with VuFind. |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks for bringing this to my attention, @EreMaijala! See below for some very minor suggestions, but this approach makes sense to me.
Thinking ahead to VuFind, I think the biggest thing we may need to do more work on is config caching support, since you're not using that here, but it's pretty valuable for VuFind performance.
| $moduleManager->initialize(); | ||
|
|
||
| // Return service manager: | ||
| return $serviceManager; |
There was a problem hiding this comment.
If you're returning the service manager, maybe you should call this container.php rather than application.php.
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
|
@demiankatz Thanks for the feedback! I've implemented the changes.
That's true. It's not an issue here, but we'll need to manage it in VuFind. |
2 participants
This eliminates dependency on Laminas MVC and its dependencies.