Remove npm check and upgrade step#216
Conversation
Removed npm upgrade step from workflow.
🔍 No files have been changedLatest commit: 976467d Please check your commit. If powered by: naverpay changeset detect-add actions |
🔍 No files have been changedLatest commit: 976467d Please check your commit. powered by: naverpay size-action |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — removing the redundant npm upgrade step is a clean simplification since the project uses pnpm.
Extended reasoning...
Overview
This PR removes a single CI step (Check and upgrade npm) from .github/workflows/publish.yaml. The removed step printed the current npm version, ran npm install -g npm@latest, then printed the upgraded version. No other files are touched.
Security Risks
None. Removing a npm install -g npm@latest step has no security implications — if anything, it reduces the surface area by not pulling an unpinned external package at runtime.
Level of Scrutiny
Minimal. This is a one-file, 8-line deletion in a CI workflow with no logic change. The project uses pnpm throughout (setup via pnpm/action-setup@v4, installs via pnpm install --frozen-lockfile), so upgrading npm was unnecessary noise.
Other Factors
No bugs were reported, no outstanding reviewer comments exist, and the change is fully mechanical. Safe to approve without human review.
3 participants
Removed npm upgrade step from workflow.
Related Issue
Describe your changes
Request