Skip to content

fix: remove npm check step and specify npm version for OIDC trusted publishing#218

Merged
yujeong-jeon merged 1 commit into
mainfrom
fix/release-ci
Apr 14, 2026
Merged

fix: remove npm check step and specify npm version for OIDC trusted publishing#218
yujeong-jeon merged 1 commit into
mainfrom
fix/release-ci

Conversation

@yujeong-jeon

Copy link
Copy Markdown
Contributor

@yujeong-jeon yujeong-jeon requested a review from a team as a code owner April 14, 2026 05:57
@yujeong-jeon yujeong-jeon changed the title fix: remove npm check step and specify npm version for OIDC trusted p… fix: remove npm check step and specify npm version for OIDC trusted publishing Apr 14, 2026
@yujeong-jeon yujeong-jeon self-assigned this Apr 14, 2026
@yujeong-jeon yujeong-jeon enabled auto-merge April 14, 2026 05:58
@npayfebot

Copy link
Copy Markdown
Collaborator

🔍 No files have been changed

Latest commit: cd73ba3

Please check your commit.

powered by: naverpay size-action

@yujeong-jeon yujeong-jeon disabled auto-merge April 14, 2026 05:59
@yujeong-jeon yujeong-jeon merged commit 3ef8c35 into main Apr 14, 2026
8 of 9 checks passed
@yujeong-jeon yujeong-jeon deleted the fix/release-ci branch April 14, 2026 05:59

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — simple and correct fix pinning npm to a specific version instead of latest for reproducible OIDC publishing.

Extended reasoning...

Overview

Single change to : replaces a verbose 'check and upgrade npm' step (which installed ) with a minimal step pinning . Referenced npm/cli#9151 confirms this is a known OIDC trusted publishing compatibility issue.

Security Risks

No security concerns. Pinning to a specific npm version is strictly safer than @latest as it improves reproducibility and avoids supply chain surprises from unexpected version bumps.

Level of Scrutiny

Low scrutiny warranted. This is a CI workflow config tweak — no application logic, no secrets handling changes, and no new permissions added.

Other Factors

No bugs found, no prior reviews, small diff (one file, ~10 lines changed). The change is clearly intentional and well-motivated.

@yujeong-jeon yujeong-jeon restored the fix/release-ci branch April 21, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants